From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) by sourceware.org (Postfix) with ESMTPS id 563643893C48 for ; Tue, 3 Aug 2021 08:49:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 563643893C48 Received: by mail-qk1-x72d.google.com with SMTP id 190so19154697qkk.12 for ; Tue, 03 Aug 2021 01:49:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JziqWTxcZRUChIhjkx93HK/j5MeykyMr3/3RNumgi2w=; b=Prhenrqc6Y0gqewPnhWpVqCtDzMUweUMkuLx/8K56JEl+o+jZ9Y+9dmhddekmJ+IX9 oe7t7tct2mukVkLUNPVPjPqAzlq7WTKK2shzA4zGmoF1Z6wIeZbgKEb7Ip2VqgaQA+kD JFfOGEtBCf5NcSwneVF4/1rOOQjN3O36slVb7bWLUYiDCjvDhOdr7dfYJqibCz0rI8hf +xnpj1DI+DV91O1vddyTIYXQrz3g53RJM5FIWpWxUoSqZNIBTh85gPYkBBXHnW3eglET WgIQJuXRdoD7X8fmhN9q/nnSEHTBM9/ZL88IsoaIX2lxZ36mA69EwdYGdjjtVpdwSRjQ ht6w== X-Gm-Message-State: AOAM530Ytte349P+hL9mizdGt6nrj13o31N4ZYPK8d36airlHn0sqaE/ ZOYNC5MMG6wH9n/vqK7pdmk/CSR8giaQREVwNxYrjA== X-Google-Smtp-Source: ABdhPJzI6iZw2KhfGHga+s/ah+iKmy57Ea9Tvi4xuihQ+LfVEohIrvLNWwiJx9egU9WpGbUnt19X+sBpPCQmt4ctVhk= X-Received: by 2002:a37:62c6:: with SMTP id w189mr19730294qkb.320.1627980585836; Tue, 03 Aug 2021 01:49:45 -0700 (PDT) MIME-Version: 1.0 References: <20210412140128.296921-1-sroettger@google.com> In-Reply-To: From: =?UTF-8?Q?Stephen_R=C3=B6ttger?= Date: Tue, 3 Aug 2021 10:49:32 +0200 Message-ID: Subject: Re: [PATCH] Update btrace data in maintenance btrace commands To: "Metzger, Markus T" Cc: "gdb-patches@sourceware.org" , Simon Marchi Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="0000000000008a750d05c8a3c41f" X-Spam-Status: No, score=-27.1 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, GIT_PATCH_0, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Aug 2021 08:49:48 -0000 --0000000000008a750d05c8a3c41f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > Let me know what you think, if you think it's valuable I'll send a v2 with the proposed change. Hey, just checking if you would like this patch, should I make the proposed change? On Wed, Jun 9, 2021 at 11:41 AM Stephen R=C3=B6ttger wrote: > Ah that makes sense. Thanks Markus and Simon. > > You're right, in the end I didn't rely on these commands. Though when I > started > playing with btrace, it did make me think btrace was broken on my machine > and > it took me a bit to figure out what's going on. So I think this change ca= n > still be valuable to save others the headache :). > Let me know what you think, if you think it's valuable I'll send a v2 wit= h > the > proposed change. > > Cheers, > Stephen > > On Tue, Jun 8, 2021 at 4:05 PM Metzger, Markus T > wrote: > > > > Hello Stephen, > > > > >On 2021-04-12 10:01 a.m., Stephen R=C3=B6ttger via Gdb-patches wrote: > > >> diff --git a/gdb/record-btrace.c b/gdb/record-btrace.c > > >> index b7b3c91f85d..79a6e47a4a6 100644 > > >> --- a/gdb/record-btrace.c > > >> +++ b/gdb/record-btrace.c > > >> @@ -269,7 +269,7 @@ require_btrace_thread (void) > > >> Throws an error if there is no thread or no trace. This functio= n > never > > >> returns NULL. */ > > >> > > >> -static struct btrace_thread_info * > > >> +struct btrace_thread_info * > > >> require_btrace (void) > > > > > >Since the doc is now in the header, write: > > > > > >/* See record-btrace.h. */ > > > > > >here. > > > > > >I'd LGTM this patch, but I'd like Markus (the btrace specialist) to > > >give it a look (I think he's away, it will be in a few weeks). > > > > Those maintenance commands are not intended for users. You'd really on= ly > > need them to debug issues with PT decode or recording. My main use-cas= e > is > > to clear the history, then turn on debugging and logging, and re-decode > the > > trace. Re-fetching shouldn't hurt but isn't necessary. > > > > Your patch LGTM (with the comment fixed) but I wonder whether there's > > anything to fix, at all. If you end up needing to use those maint > commands, > > something else may be wrong. > > > > Regards, > > Markus. > > > > Intel Deutschland GmbH > > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany > > Tel: +49 89 99 8853-0, www.intel.de > > Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Sil= va > > Chairperson of the Supervisory Board: Nicole Lau > > Registered Office: Munich > > Commercial Register: Amtsgericht Muenchen HRB 186928 > --0000000000008a750d05c8a3c41f Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIPngYJKoZIhvcNAQcCoIIPjzCCD4sCAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg ggz4MIIEtjCCA56gAwIBAgIQeAMYYHb81ngUVR0WyMTzqzANBgkqhkiG9w0BAQsFADBMMSAwHgYD VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE AxMKR2xvYmFsU2lnbjAeFw0yMDA3MjgwMDAwMDBaFw0yOTAzMTgwMDAwMDBaMFQxCzAJBgNVBAYT AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMSowKAYDVQQDEyFHbG9iYWxTaWduIEF0bGFz IFIzIFNNSU1FIENBIDIwMjAwggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQCvLe9xPU9W dpiHLAvX7kFnaFZPuJLey7LYaMO8P/xSngB9IN73mVc7YiLov12Fekdtn5kL8PjmDBEvTYmWsuQS 6VBo3vdlqqXZ0M9eMkjcKqijrmDRleudEoPDzTumwQ18VB/3I+vbN039HIaRQ5x+NHGiPHVfk6Rx c6KAbYceyeqqfuJEcq23vhTdium/Bf5hHqYUhuJwnBQ+dAUcFndUKMJrth6lHeoifkbw2bv81zxJ I9cvIy516+oUekqiSFGfzAqByv41OrgLV4fLGCDH3yRh1tj7EtV3l2TngqtrDLUs5R+sWIItPa/4 AJXB1Q3nGNl2tNjVpcSn0uJ7aFPbAgMBAAGjggGKMIIBhjAOBgNVHQ8BAf8EBAMCAYYwHQYDVR0l BBYwFAYIKwYBBQUHAwIGCCsGAQUFBwMEMBIGA1UdEwEB/wQIMAYBAf8CAQAwHQYDVR0OBBYEFHzM CmjXouseLHIb0c1dlW+N+/JjMB8GA1UdIwQYMBaAFI/wS3+oLkUkrk1Q+mOai97i3Ru8MHsGCCsG AQUFBwEBBG8wbTAuBggrBgEFBQcwAYYiaHR0cDovL29jc3AyLmdsb2JhbHNpZ24uY29tL3Jvb3Ry MzA7BggrBgEFBQcwAoYvaHR0cDovL3NlY3VyZS5nbG9iYWxzaWduLmNvbS9jYWNlcnQvcm9vdC1y My5jcnQwNgYDVR0fBC8wLTAroCmgJ4YlaHR0cDovL2NybC5nbG9iYWxzaWduLmNvbS9yb290LXIz LmNybDBMBgNVHSAERTBDMEEGCSsGAQQBoDIBKDA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5n bG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzANBgkqhkiG9w0BAQsFAAOCAQEANyYcO+9JZYyqQt41 TMwvFWAw3vLoLOQIfIn48/yea/ekOcParTb0mbhsvVSZ6sGn+txYAZb33wIb1f4wK4xQ7+RUYBfI TuTPL7olF9hDpojC2F6Eu8nuEf1XD9qNI8zFd4kfjg4rb+AME0L81WaCL/WhP2kDCnRU4jm6TryB CHhZqtxkIvXGPGHjwJJazJBnX5NayIce4fGuUEJ7HkuCthVZ3Rws0UyHSAXesT/0tXATND4mNr1X El6adiSQy619ybVERnRi5aDe1PTwE+qNiotEEaeujz1a/+yYaaTY+k+qJcVxi7tbyQ0hi0UB3myM A/z2HmGEwO8hx7hDjKmKbDCCA18wggJHoAMCAQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUA MEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9vdCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWdu MRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEg MB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENBIC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzAR BgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4 Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0EXyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuu l9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+JJ5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJ pij2aTv2y8gokeWdimFXN6x0FNx04Druci8unPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh 6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTvriBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti +w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGjQjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8E BTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5NUPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEA S0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigHM8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9u bG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmUY/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaM ld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88 q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcya5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/f hO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/XzCCBNcwggO/oAMCAQICEAGAQ3TCDBAfTkR9ZOt0 uXEwDQYJKoZIhvcNAQELBQAwVDELMAkGA1UEBhMCQkUxGTAXBgNVBAoTEEdsb2JhbFNpZ24gbnYt c2ExKjAoBgNVBAMTIUdsb2JhbFNpZ24gQXRsYXMgUjMgU01JTUUgQ0EgMjAyMDAeFw0yMTA2MjQw NTE5MTFaFw0yMTEyMjEwNTE5MTFaMCUxIzAhBgkqhkiG9w0BCQEWFHNyb2V0dGdlckBnb29nbGUu Y29tMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA0dhDiOVgwZ20Sd+pv+GOrHKcGjet dgVLMjHrLnsZqgONHCLZXH4dxfjez/McaaxwbBGOhumUZRXQPeWfGa2/kFDLkO3tVanR4B2vtB9X CpXpsTUCwRmedDLsw78vlY2dVzZt4MhBLPbp4DMc9fBAi8h/C5o9BPMHKPzooIjVJ0dGf7egCyG0 neQ8oe+sh0ffFB3OTY1Xe/zNHVsBGDf2WY7qKg2B4aRXEFmQYfVDQBYXEaNEJSFf3a5AMTr02U0S ZZ/NjxOhX5Ea+7I77jyINOoTXmzChIbGelK6LHScMgyJHMrEoC5yKDuW+iG5yx2IDCLlRvneF1MP IAas/OsdqQIDAQABo4IB0jCCAc4wHwYDVR0RBBgwFoEUc3JvZXR0Z2VyQGdvb2dsZS5jb20wDgYD VR0PAQH/BAQDAgWgMB0GA1UdJQQWMBQGCCsGAQUFBwMEBggrBgEFBQcDAjAdBgNVHQ4EFgQU2ts0 H1D1yHzV9Fzhn2iBfzS9NuowTAYDVR0gBEUwQzBBBgkrBgEEAaAyASgwNDAyBggrBgEFBQcCARYm aHR0cHM6Ly93d3cuZ2xvYmFsc2lnbi5jb20vcmVwb3NpdG9yeS8wCQYDVR0TBAIwADCBmgYIKwYB BQUHAQEEgY0wgYowPgYIKwYBBQUHMAGGMmh0dHA6Ly9vY3NwLmdsb2JhbHNpZ24uY29tL2NhL2dz YXRsYXNyM3NtaW1lY2EyMDIwMEgGCCsGAQUFBzAChjxodHRwOi8vc2VjdXJlLmdsb2JhbHNpZ24u Y29tL2NhY2VydC9nc2F0bGFzcjNzbWltZWNhMjAyMC5jcnQwHwYDVR0jBBgwFoAUfMwKaNei6x4s chvRzV2Vb4378mMwRgYDVR0fBD8wPTA7oDmgN4Y1aHR0cDovL2NybC5nbG9iYWxzaWduLmNvbS9j YS9nc2F0bGFzcjNzbWltZWNhMjAyMC5jcmwwDQYJKoZIhvcNAQELBQADggEBADPhmacGDFenqV1M tN9lRcNKhJ7oeVEpRlFRq7dT6DlBAoLk0nPgAPISVkKp0/swywo10onFGCd6gsqJ+DkknflERZGf XvAY8bA4s9nDGod9Bfm/nm43cEIfS/kO0n6iIOmNfH005wKT48ofEnOaqpl5Ce5T+2njfwi91Pfr j5JyqSo8VZjoHJ8s7BuB4VS+SAuAN+fUgDyY2H0r2m32sECjm8/Aq2lVZX44JhfoOyoTTcufCrZ0 JoMNIGENrRuGD2DMQslIfX2kKloOPZNvQBYQAaCd+dPUT18xxFyUQ0D2/cFpa7vmZXkqrRIZ0Oe2 nGCBvf8J/MoErcTldnEStwkxggJqMIICZgIBATBoMFQxCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBH bG9iYWxTaWduIG52LXNhMSowKAYDVQQDEyFHbG9iYWxTaWduIEF0bGFzIFIzIFNNSU1FIENBIDIw MjACEAGAQ3TCDBAfTkR9ZOt0uXEwDQYJYIZIAWUDBAIBBQCggdQwLwYJKoZIhvcNAQkEMSIEICiu 1gw8vbM6ONt95AoaBWDC+42UENqfBt8pPqRH1yoeMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEw HAYJKoZIhvcNAQkFMQ8XDTIxMDgwMzA4NDk0NlowaQYJKoZIhvcNAQkPMVwwWjALBglghkgBZQME ASowCwYJYIZIAWUDBAEWMAsGCWCGSAFlAwQBAjAKBggqhkiG9w0DBzALBgkqhkiG9w0BAQowCwYJ KoZIhvcNAQEHMAsGCWCGSAFlAwQCATANBgkqhkiG9w0BAQEFAASCAQAFfI4btKoiR88t9vlNOjh3 0lYCHqnOxEFaYWHNgp0mQicwKq34oXfGmFaqY/zmDgX2C5LJzPfZUe8MC8OsfTvgfCit7W35ylI+ T8DaZLnbGgqCVH6CXphuqqqMpFUFJI35ZnCKT+4B18mjJwzFuN4Zqnd69Z+qfzFnU4eAgldmFcyb dI0jV3513ziC4oVlCWiF83iPHq+4QZbhNP8O4JQfUATiWT2nYbOOi+M9W0wkv6jwVCeJmpVoFOh/ uDAY6XYbbx94uN3n+JDt4M5ul/Aaax0NfPr74VRYNalUOJL7KY5Zk2RVbPJMW6gdbBsdpUEX7J2S ma34CAZUCMdC0yyq --0000000000008a750d05c8a3c41f--