From: Manish Goregaokar <manish@mozilla.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Initialize strtok_r's saveptr to NULL
Date: Wed, 29 Jun 2016 15:30:00 -0000 [thread overview]
Message-ID: <CAFOnWknqP38V-Hsswxu_XdRiLk6B1NOkjQdf+sRbJCWR7JjUHQ@mail.gmail.com> (raw)
In-Reply-To: <096d4eba-1f36-1a1c-055e-331353293364@redhat.com>
Yipes, sorry about that. Copy-paste error :)
-Manish
On Wed, Jun 29, 2016 at 8:42 PM, Pedro Alves <palves@redhat.com> wrote:
> On 06/29/2016 03:42 PM, Manish Goregaokar wrote:
>> Fixed and pushed.
>
> Thanks. Please don't put the "gdb/ChangeLog:" lines in the
> ChangeLog file though. :-)
>
>>
>> Is this something we can fix in gcc? Pointer overflow is UB IIRC so
>> <nonnullptr>+<positive thing> should never be null. Not sure if the
>> compiler knows that this is positive though.
>
> I'd hope so. Was already working on a minimal reproducer. :-)
> Filed a gcc bug now:
>
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71699
>
> Thanks,
> Pedro Alves
>
next prev parent reply other threads:[~2016-06-29 15:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 12:45 Manish Goregaokar
2016-06-29 14:25 ` Pedro Alves
2016-06-29 14:42 ` Manish Goregaokar
2016-06-29 15:12 ` Pedro Alves
2016-06-29 15:30 ` Manish Goregaokar [this message]
2016-06-29 15:55 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFOnWknqP38V-Hsswxu_XdRiLk6B1NOkjQdf+sRbJCWR7JjUHQ@mail.gmail.com \
--to=manish@mozilla.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).