From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by sourceware.org (Postfix) with ESMTPS id 07E313858C78; Mon, 4 Dec 2023 13:13:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 07E313858C78 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 07E313858C78 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701695601; cv=none; b=Nd0JmS2suS9yORboPdkDyp5InYtkbO3u8FBwcBlpTgNsyPnKQ20k74kNlFjPOLxiCKXBlTO1JVzB3aCY7ajxIE1nbCKRsp0oBOxbs3b364ok3htGQibhjK8rtzm12yGxEErGNY82+IQ2nO9/9ychldcL4ePPgdnPugyv2QkzbrY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701695601; c=relaxed/simple; bh=ZZ5kprpG2NB08nhkXdn9ftBpb4GuuwB0Co0se8jArVk=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=Ax3a+XvnOoknni6iWaC/WnMlIzmZjx5XIJVYZJDEFvFRB3Gy5KXpukia+pYPVaDEvV4vSUdnPp/2NV/yloWNULt28GcHoBSx/Ck/BzH4Smv7Jk9eLL1qKsqbxkFnVlvimY+plDCenc7UOLkNgQTrfng3f/250HilsG6Pi3SZqcM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-50bf2d9b3fdso1519946e87.3; Mon, 04 Dec 2023 05:13:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701695596; x=1702300396; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=1vH4ztwkNEARE/yFaVRl71BBUorTCKMO+Ifael8hvQk=; b=P1XK4AF28wfXJJJlPltfKTDKnrL8o4aTN3n6Euu5HhGkdytyQqtEVvNQEEfkCPplJF 0ZqCGY2hYvCkvJZkgKMMxSomA8KCtT4/AcYeo4HcUc/PnlagKoa+cSAU5bHvbp9rZPha 6Ki73rgUuYKpthmRL9zgi3rlw+kL6fiyZaPW/7TDL8pENv7wgCTgt+zDEqiHajdLvPYH 5+sfLi+/PW9j06F6Xu7nLAQzC3GdyE2AebVOdXDkLtzEYIZTtzCIManRlSG8ag+z9HhZ nxCY14Ir/zQtn/2ARo01gKYmnt7ThF8I7vWmsbOHM6/agS/bDAJ8nFIemOrGdl1LW1N/ /sFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701695596; x=1702300396; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1vH4ztwkNEARE/yFaVRl71BBUorTCKMO+Ifael8hvQk=; b=NGwKn9iKH1k72sW2I9vYeDA+ka4XboYuuo7+WZbhd3jPIihTRS/Z2MxztdOvFeqH4n AXmO20GcYQIBjNdzs0UsWRvCpVwYB1ncITsr7rbTqe32NgLZUdXX/mu0bdebg6HGkcMN qgJF/qGwaTTS5nev7MQG1W3sbrUcZyADjhgoMOt9a9wTIyKR8Fbbyst3idwEnEv/IOjw aNZERC90s/kjvUihYIW45JMjUYsS/3Duw5+zd1D2lzF4N9GNTvK7LsHDhllCdtTixBvo /BnObP/519Oe1EY7wwmjUgs3OhGT8ZeyhmW+J2DBf9Mq5t9JXxtWdZFbzTZXRUwPQDDn IOSA== X-Gm-Message-State: AOJu0YxRCBOJsc4IEV9fb1j1cu/9Le0Qz8cYFwOsEZiaV8lLOMt/6e5G DbGoILntwYsxKhRvMCUlOPiMRxPam69hGhWAZc0TJph2 X-Google-Smtp-Source: AGHT+IGRG7xI3z7PB0TBF9UnnFDeD+Gpn0jW+0unZorKa+ZRSUyUZJloPd24wlbGUKBbdBkMQ8ydA+cAIuprohV44bE= X-Received: by 2002:a05:6512:1150:b0:50b:d764:76d6 with SMTP id m16-20020a056512115000b0050bd76476d6mr3264489lfg.101.1701695596091; Mon, 04 Dec 2023 05:13:16 -0800 (PST) MIME-Version: 1.0 References: <20231202141722.1323526-2-arsen@aarsen.me> In-Reply-To: <20231202141722.1323526-2-arsen@aarsen.me> From: Richard Biener Date: Mon, 4 Dec 2023 14:13:02 +0100 Message-ID: Subject: Re: [PATCH] gettext: disable install, docs targets, libasprintf, threads To: =?UTF-8?Q?Arsen_Arsenovi=C4=87?= Cc: gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org, binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sat, Dec 2, 2023 at 5:03=E2=80=AFPM Arsen Arsenovi=C4=87 wrote: > > This fixes issues reported by David Edelsohn , and by > Eric Gallager . > > ChangeLog: > > * Makefile.def (gettext): Disable (via missing) > {install-,}{pdf,html,info,dvi} and TAGS targets. Set no_install > to true. Add --disable-threads --disable-libasprintf. Drop the > lib_path (as there are no shared libs). > --- > Afternoon, > > This patch disables various targets and features on the gettext module > to fix problems reported by David Edelsohn and Eric Gallager in > https://inbox.sourceware.org/CAGWvnynmWgNjup4cAwSbsy1vw_MJLQqSULwM=3DkTH_= +Lt+_smbg@mail.gmail.com/ > and followups and on IRC, respectively. > > The gettext module does not actually require any of these to be usable > for the purposes of the toolchain, so disabling them seems to be a > decent workaround. > > This seemed to fix the respective issues for both Eric and David, > though, I could not get GDB to build on AIX with or without this patch > applied (I needed to disable sim, gdb and gnulib modules). > > It is possible I am missing something. Due to some unfortunate > circumstances, it's taken more time than anticipated to actually get > this change tested, and I've had to context swap quite a few bits. Such > a process has quite a lot of room for error. > > Tested on x86_64-unknown-freebsd13.2. OK. > Makefile.def | 13 +++- > Makefile.in | 202 ++++++++------------------------------------------- > [removed regenerated file from the patch below] > 2 files changed, 40 insertions(+), 175 deletions(-) > > diff --git a/Makefile.def b/Makefile.def > index 792f81447e1b..ba89d46b2495 100644 > --- a/Makefile.def > +++ b/Makefile.def > @@ -80,8 +80,17 @@ host_modules=3D { module=3D gettext; bootstrap=3Dtrue;= no_install=3Dtrue; > // need it in some configuratons, which is determined via= nontrivial tests. > // Always enabling pic seems to make sense for something = tied to > // user-facing output. > - extra_configure_flags=3D'--disable-shared --disable-java= --disable-csharp --with-pic'; > - lib_path=3Dintl/.libs; }; > + extra_configure_flags=3D'--disable-shared --disable-threa= ds --disable-java --disable-csharp --with-pic --disable-libasprintf'; > + missing=3D pdf; > + missing=3D html; > + missing=3D info; > + missing=3D dvi; > + missing=3D install-pdf; > + missing=3D install-html; > + missing=3D install-info; > + missing=3D install-dvi; > + missing=3D TAGS; > + no_install=3D true; }; > host_modules=3D { module=3D tcl; > missing=3Dmostlyclean; }; > host_modules=3D { module=3D itcl; }; > diff --git a/Makefile.in b/Makefile.in > index da2344b3f3dc..3bd7d37e9605 100644 > > -- > 2.43.0 >