From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by sourceware.org (Postfix) with ESMTPS id B06DF3848000 for ; Wed, 10 Feb 2021 20:57:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B06DF3848000 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=jimw@sifive.com Received: by mail-ed1-x531.google.com with SMTP id v7so4627788eds.10 for ; Wed, 10 Feb 2021 12:57:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kPD7VRiQ2gj7GAYLHLEOVFtcAyZ6GEJtgHWAf+wF5Zg=; b=J/L/6kW8GOLAQx6OKQuhPAHKTNXZSYzmlZYUR1vQir+H0SOMQ+Y0kC3Tgcl13JDgkz 6FIHSQ1exe9FWKX4R8PGFgkTRYUaQCazc5Rb5jhNG+BR0HfddxxYrPi4wzi9D+q4Cazp bUFq83hyO+/xngEDAcxvafsJ1SAbPkdrU6kmRnue6lIkWYd4GhvlDfX1/8DSSLMExLmo URL+UEfeYmBzqEHEedoHbqR+3IscAW+EYKrQXYF9226ZmXq/N5rf/gMHpIw5GIoBcnzY aETp8WoBe1bW55JFI/1I2jDZeeuABqpOFlmiuVknFftT3fwTAIYaOx/bXhsF1zL5OPpx GhaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kPD7VRiQ2gj7GAYLHLEOVFtcAyZ6GEJtgHWAf+wF5Zg=; b=qIkq/yhlsTKkoei/8h84b4R10sE799jxkGZSIWID1r4+xmqiUHCNrCesYgKwkud8m/ aDFUePOlnILoOEnGoMtbdvD6cR5v5EevtSsCO8L1B1MCwLtI5rHu7VRY/5YuiQV7qhXH WddTultui5nTC5vsAbDBw8vB6d+3ivZDa0sUuX3OCRLV72I8mkwKpe3bxDFbgvyh33Up QIohkuQaekjXnlkfsr+awamCI/sYzWItGb994JBWjfJxYG5+ampjAkFGI2BwAohvR5hV PVkCJfIv1o9mDVs1wKffPWLP0Q7hPofI6WkERh3BWprGFjIEX0RZaRod1N9Q0ZxDlfiA djRg== X-Gm-Message-State: AOAM532WdMeB9EcmQOgqpXnk8UqEvZjpzjSCnoScMxoAgkxgHDCXkiQO SK7YnHtDOHAaOVXxGM2d7BDfe7BFd/zuP/JUmZqj0gxu4Km1sw== X-Google-Smtp-Source: ABdhPJxPq2k9KQr7LQMFl23Me/iIap8PQLjKir+6M2J1aO6egKVhuqlavhb+LhehYc20g4iwT0sSbIk86RqTFp8YP7U= X-Received: by 2002:a05:6402:125a:: with SMTP id l26mr5175900edw.188.1612990641854; Wed, 10 Feb 2021 12:57:21 -0800 (PST) MIME-Version: 1.0 References: <9379a3e1af978103cfa47e869594f0df91d807ea.1611172468.git.andrew.burgess@embecosm.com> In-Reply-To: <9379a3e1af978103cfa47e869594f0df91d807ea.1611172468.git.andrew.burgess@embecosm.com> From: Jim Wilson Date: Wed, 10 Feb 2021 12:57:10 -0800 Message-ID: Subject: Re: [PATCHv2 4/9] bfd/riscv: prepare to handle bare metal core dump creation To: Andrew Burgess Cc: gdb-patches@sourceware.org, Binutils , Fredrik Hederstierna X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Feb 2021 20:57:24 -0000 On Wed, Jan 20, 2021 at 12:24 PM Andrew Burgess wrote: > bfd/ChangeLog: > > * elfnn-riscv.c (riscv_write_core_note): New function. > (elf_backend_write_core_note): Define. > This looks OK. In the PRPSINFO code you are using hardwired constants in the strncpy calls. Maybe you can compute them from macros instead to make sure that we don't end up with problems later if type sizes change? > > + strncpy (data + PRPSINFO_OFFSET_PR_FNAME, va_arg (ap, const char > *), 16); > Maybe the 16 can be PRPSINFO_OFFSET_PR_PID. > > + strncpy (data + PRPSINFO_OFFSET_PR_PSARGS, va_arg (ap, const char > *), 80); > Maybe the 80 can be PRPSINFO_SIZE - PRPSINFO_OFFSET_PR_PSARGS. it looks like you already did something similar with the memcpy call in the PRSTATUS code so that looks OK. Jim