public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Jim Wilson <jimw@sifive.com>
To: gdb-patches@sourceware.org
Cc: Andrew Burgess <andrew.burgess@embecosm.com>
Subject: [PATCH 0/3] RISC-V: gdb.base/gnu_vector fixes.
Date: Tue, 06 Nov 2018 21:43:00 -0000	[thread overview]
Message-ID: <CAFyWVaYMo6sOfXQqZ3YuRyjSnsfGSB9vZTO43j6hKRva73_TCA@mail.gmail.com> (raw)

This set of patches fixes these infcall related failures on a rv64gc
linux system.
FAIL: gdb.base/gnu_vector.exp: call add_many_charvecs
FAIL: gdb.base/gnu_vector.exp: call add_various_floatvecs

The first one fails because we have 2 4-byte vector args passed in the
same 8-byte stack slot.  The code is failing round up the address of a
stack slot when an arg is smaller than the stack slot size.

The second one fails because of two problems.  The 16-byte vector of
floats is given 4 byte alignment when it should have 16 byte
alignment. This is because there is no support for vector types.  And
unnamed args that require twice XLEN alignment are supposed to be
passed in aligned register pairs.  The support for this is also
missing.

This was tested on a rv64gc linux system with the gdb testsuite, and
it fixes 2 failures without causing any regressions.

Jim

             reply	other threads:[~2018-11-06 21:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-06 21:43 Jim Wilson [this message]
2018-11-06 21:44 ` [PATCH 1/3] " Jim Wilson
2018-11-08 15:43   ` Andrew Burgess
2018-11-13  1:52     ` Jim Wilson
2018-11-06 21:44 ` [PATCH 2/3] " Jim Wilson
2018-11-08 14:37   ` Andrew Burgess
2018-11-06 21:44 ` [PATCH 3/3] " Jim Wilson
2018-11-08 14:34   ` Andrew Burgess
2018-11-08 14:44     ` Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFyWVaYMo6sOfXQqZ3YuRyjSnsfGSB9vZTO43j6hKRva73_TCA@mail.gmail.com \
    --to=jimw@sifive.com \
    --cc=andrew.burgess@embecosm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).