From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by sourceware.org (Postfix) with ESMTPS id BF76838930F5 for ; Wed, 21 Apr 2021 23:01:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BF76838930F5 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=jimw@sifive.com Received: by mail-ej1-x62b.google.com with SMTP id u17so65894321ejk.2 for ; Wed, 21 Apr 2021 16:01:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=3yN1k0+d5iKJlIP6FJoseLskBLJ3I2JfdHa/oI+GRyY=; b=aPziTpzgtRsv6jqn0kwdU9NhG1W/roAowv6NRcm6OT+vsjlezY/6gPaZCp96XjWWD0 T3/7zVnQODDZPOhSuDphokdnlniO9dDxdm+eqn5xjPCQngAZ6L259k9zQXDwHOYyecg6 DTcNJqgdlAJC52O67+g6Q+l5o45YvSOQ/BhAmlLG28C25NPxDWwueypO5ChY8vlG3D7t Y4H5QUGxXLEn1swxcJgln+zrsULRHQfJQuAS73Xt1CFETvBFFDdt77DYVHCoixqr4m2J KIhVL4hw8g23GEc3zhHw2fYFXWR7yPTIaEOBKDtUcP2FpwOqGGW/LWtD5ieaLuwhbr3Z 49dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=3yN1k0+d5iKJlIP6FJoseLskBLJ3I2JfdHa/oI+GRyY=; b=TdS1mEPvs5oa4Klug159kIVYfLTVdOiLB6jPepzpj1gpbd5VamolX7aFPD10y+pL+w CtfUAyzBLUYxfHyMNAoMSpvzaAXzotxpPmSUwztaQ/Nnj4vCRzy/i/KR4hUjV4/siEV6 ctBOmcejtqpYLdP2+chNGJ4SoLwS/v6n3yhhAHHObH2btzvpf74pxh0maf2NqKJ6f8Qh PWrw29lXILEZDSxakvqIxcV1sifD95XpY9dB6SF/jj9FJjF292yS6hhxIrVuayANgqZu NEKlvHHKrAYO+Ibp6KHia5HwRO3nRYfunRsrW5RJww9Sd074kvqVI+E28Pl24kQVWgTO cspA== X-Gm-Message-State: AOAM533krf4XNoS/oW8cCgk5LQn4+LbUeVxZx5EqbwoguMpQRrjacqN0 kDDvPj5Ls/tzVAj6NfseDou4TEE0au5pfjm5YMf3UA== X-Google-Smtp-Source: ABdhPJzjE0aTVQlT6avdbX0um3SEjECV+Lm/kqe0BV2l4KNm617ql2oLvR41nJ14k7zhUNPvEPmVcrXaFF/LdkDxl3I= X-Received: by 2002:a17:906:cf8f:: with SMTP id um15mr159072ejb.547.1619046066912; Wed, 21 Apr 2021 16:01:06 -0700 (PDT) MIME-Version: 1.0 References: <20210417175831.16413-1-jimw@sifive.com> <20210417175831.16413-4-jimw@sifive.com> In-Reply-To: From: Jim Wilson Date: Wed, 21 Apr 2021 16:00:55 -0700 Message-ID: Subject: Re: [PATCH 03/24] RISC-V sim: Atomic fixes. To: Jim Wilson , gdb-patches@sourceware.org, Kito Cheng X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Apr 2021 23:01:09 -0000 On Sun, Apr 18, 2021 at 8:56 PM Mike Frysinger wrote: > On 17 Apr 2021 10:58, Jim Wilson wrote: > > Handle aq and rl. Fix wrong value when rd is zero register. Fix > > amoswap when rd and rs2 are the same register. > > lgtm. can you add tests for these things, and for the other fixes ? > Tests for these amo issues would be useful, as this isn't well tested by the gcc testsuite. I will look into that. Most of the other stuff is well tested just by running the gcc testsuite. I'm working on the gdb sim as a side project while working on other projects, and if I have to write a lot of tests there could be a significant delay in completing the patch set. I'd prefer if some of this stuff could be handled with follow up patches. Jim