From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by sourceware.org (Postfix) with ESMTPS id C1F043857C74 for ; Wed, 21 Apr 2021 23:43:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C1F043857C74 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=jimw@sifive.com Received: by mail-ej1-x631.google.com with SMTP id v6so64646584ejo.6 for ; Wed, 21 Apr 2021 16:43:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=J11rrrU60V4ZTk3avmpelOJn341V8JL+W1wV4HeCR7s=; b=LF6X8zI/ZA4vxe56bgdbAFUjcO9cftCb+sy1kjHC9i3qM86gRuSQEV1n2hPHHPdfVC C4i9s+hPqyfLPPSykv2mCG1a+0IbtaYQIJiYJA7r/hm0j9Sk02hSWVRL3MWjUZlDzTMC TNUgiWMzkd5jMYytO0v981rBmGvN/YWh9YMUBBstSkG82gXb8/7XN59jNeWZNs5qWgfJ aK5Yaqm7K2WDLu/zdP7W4LFiCNWeBbKunb+vpfcGZitXUWSl56R/4RRxn+zvyeR6qQA0 EZHkymjM480aNhdm1e3bgzaKTJTKxV04DXPJ0PULcAhx++VY5ZGrr9c4IszyzqNF6T94 N3JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=J11rrrU60V4ZTk3avmpelOJn341V8JL+W1wV4HeCR7s=; b=VaRUZlUPn5pvE0BfqKIFiHdLRxdRIDinV6A043w2oovI/udT+odaGbAq/fR/DD7vgP FfmibUjQVaFDPWDojDIR8pceXOlfX6YtL0JaT3YknfeafDkVUWPJ1+9cmiN4TlkOVm3I JkY5BnXiR0T62GtjNkn/6fFW/zVbFrfHjr/ycHo/tQHn7May7pYWrVwhEZrAuQow+zhr sBgZIL7KF/e6HH2mx1p9GAauHlDIKnrSluEa7/31WuwyUWKlHVljFriq4cc8z8ASxRch J5SXSv9Jj/+FFI6TazST2Znp9dRDd2wtjrN4ikWlsvAPD7c4OBEyjbJHboGbcFkHfblD WIng== X-Gm-Message-State: AOAM53075ZCYamMv8EV0Cra77itudLA/snPkEMDSF6U+SdqSTjUptngU Xl0XrV+EqPFM93D746UhhmgQgmUiT6+OpTKJWHMiKU0iYQo= X-Google-Smtp-Source: ABdhPJyHBzKLblhiaBwZUNVR6HjXHLX/2Ttk+R74LiEcmUQHdppDB5KaJTdOoMsMTkKy921NjjJcMzpTO362syrO9O8= X-Received: by 2002:a17:907:6e1:: with SMTP id yh1mr351453ejb.486.1619048581842; Wed, 21 Apr 2021 16:43:01 -0700 (PDT) MIME-Version: 1.0 References: <20210417175831.16413-1-jimw@sifive.com> <20210417175831.16413-13-jimw@sifive.com> In-Reply-To: From: Jim Wilson Date: Wed, 21 Apr 2021 16:42:50 -0700 Message-ID: Subject: Re: [PATCH 12/24] RISC-V sim: Add compressed support. To: Jim Wilson , gdb-patches@sourceware.org, Monk Chiang X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Apr 2021 23:43:04 -0000 On Sun, Apr 18, 2021 at 9:13 PM Mike Frysinger wrote: > On 17 Apr 2021 10:58, Jim Wilson wrote: > > Add C instruction support. > > lgtm other than missing tests > This is well tested by the gcc testsuite. I'd rather handle missing tests with bug reports and follow on patches. Jim