From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 109393 invoked by alias); 8 Nov 2018 21:57:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 109383 invoked by uid 89); 8 Nov 2018 21:57:25 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=hec, market X-HELO: mail-vs1-f41.google.com Received: from mail-vs1-f41.google.com (HELO mail-vs1-f41.google.com) (209.85.217.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 08 Nov 2018 21:57:23 +0000 Received: by mail-vs1-f41.google.com with SMTP id h18so12562771vsj.4 for ; Thu, 08 Nov 2018 13:57:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dFOLwutFRe1WwMgYkS0ixFchwmEeMk+gKbQwyGMeT2I=; b=lN19vPBKuVZQ2i33oc6g4kFC1XnF/Hm+teeMKvKsU5qicSqhDA2nGBGRRkgTl+yfPL f5b9I6NqA91wxVe0tkrk2FBCK6hnimPxUFlU0JB2lUyzrMW0uO1qO8Z2kEMOk3lytipm nb8C3u3MRVVfVnPIqSXhcHKGWENmigHIvlCx7rjTaKQ9q6/5SK4jAFoiLqpIcc3jH3X2 +iPHNaP/A0MoJT1C7tjFTxOy0XotSVE8jzNilzLsrPSjkU4OVK8qGOI36uJMOUQAfFzs sZMEQhmNJxSEB4TB7WGw+1Egf6vS6U36Byo56N0KO1VxlBWU7PHoB6D4m4WTJOjpTh2f NOeA== MIME-Version: 1.0 References: <20181108160745.24600-1-andrew.burgess@embecosm.com> In-Reply-To: <20181108160745.24600-1-andrew.burgess@embecosm.com> From: Jim Wilson Date: Thu, 08 Nov 2018 21:57:00 -0000 Message-ID: Subject: Re: [RFC] gdb/riscv: Add target description support To: Andrew Burgess Cc: gdb-patches@sourceware.org, Palmer Dabbelt , John Baldwin Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2018-11/txt/msg00133.txt.bz2 On Thu, Nov 8, 2018 at 8:07 AM Andrew Burgess wrote: > riscv*-*-linux*) > # Target: Linux/RISC-V > - gdb_target_obs="riscv-linux-tdep.o riscv-tdep.o glibc-tdep.o \ > + gdb_target_obs="riscv-linux-tdep.oglibc-tdep.o \ > linux-tdep.o solib-svr4.o symfile-mem.o linux-record.o" There is a typo here, a space is missing between riscv-linux-tdep.o and glibc-tdep.o. Otherwise this looks great. I tested it on riscv64-linux and saw no new problems. I also tested with riscv-tests/debug against openocd, and almost everything that failed before is now passing. There are two tests that fail because riscv-tests/debug doesn't know how to parse the new {float...double...} string output for FP registers. There are two tests that fail for a 32-bit target with (gdb) p/x fox = "This little piggy went to the market." p/x fox = "This little piggy went to the market."^M /scratch/jimw/openocd/fsf-gdb/riscv-gnu-toolchain/build/../riscv-gdb/gdb/regcac\ he.c:298: internal-error: void regcache::restore(readonly_detached_regcache*): \ Assertion `src != NULL' failed.^M And the same tests fail for a 64-bit target with a timeout. That may only be one problem. This should not prevent the XML register set support from going in now, and we can worry about debugging these problems later. Even with the failures this is a major improvement over what we had before. Jim