public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Jim Wilson <jimw@sifive.com>
To: kevinb@redhat.com
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] RISC-V: Linux signal frame support.
Date: Fri, 26 Oct 2018 17:34:00 -0000	[thread overview]
Message-ID: <CAFyWVaanMWpzkxBOBteDY9bZ7pEy4xFSrFUwVFG9i32L8UN1Rg@mail.gmail.com> (raw)
In-Reply-To: <20181025202529.5b52880e@pinnacle.lan>

On Thu, Oct 25, 2018 at 8:25 PM Kevin Buettner <kevinb@redhat.com> wrote:
>
> On Thu, 25 Oct 2018 16:59:35 -0700
> Jim Wilson <jimw@sifive.com> wrote:
>
> > Make riscv_isa_flen available to the linux native code, and clean up duplicate
> > comments.
> >
> >       gdb/
> >       * riscv-tdep.c (riscv_isa_xlen): Refer to riscv-tdep.h comment.
> >       (riscv_isa_flen): Likewise.  Drop static.
> >       * riscv-tdep.h (riscv_isa_xlen): Move riscv-tdep.c comment to here.
> >       (riscv_isa_flen): Likewise.
>
> Maybe:
>
>         (riscv_isa_flen): Likewise; declare.
>
> ?
>
> Otherwise, LGTM.

Thanks.  Committed with the corrected ChangeLog entry.

Jim

  reply	other threads:[~2018-10-26 17:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-25 23:59 [PATCH 0/2] " Jim Wilson
2018-10-25 23:59 ` [PATCH 1/2] " Jim Wilson
2018-10-26  3:25   ` Kevin Buettner
2018-10-26 17:34     ` Jim Wilson [this message]
2018-10-26  0:01 ` [PATCH 2/2] " Jim Wilson
2018-10-26  3:58   ` Kevin Buettner
2018-10-26 16:26   ` John Baldwin
2018-10-26  7:32 ` [PATCH 0/2] " Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFyWVaanMWpzkxBOBteDY9bZ7pEy4xFSrFUwVFG9i32L8UN1Rg@mail.gmail.com \
    --to=jimw@sifive.com \
    --cc=gdb-patches@sourceware.org \
    --cc=kevinb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).