From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by sourceware.org (Postfix) with ESMTPS id B43CA3857C74 for ; Thu, 22 Apr 2021 03:12:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B43CA3857C74 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=jimw@sifive.com Received: by mail-ed1-x52b.google.com with SMTP id cq11so8049313edb.0 for ; Wed, 21 Apr 2021 20:12:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=00PxBbfbrNZbkmqCqXfLs9yZ97MS3BWWQWlUZ8BdVkg=; b=VxVKrXvLVAFHr13XS4s/tZyVst7Wrrqqj5ADtw0BLC34fPNH3Zh1cJvP6lTJ5NM46X b147jGtKX5Q7n7F2J0vWovx/HP26EcYfLRv30zaYEqB1YPDceouyvJuLV59i+nMGUAVh Ci/X+nQCzj9rvM5Tbw2x0TcIRfP7fjoKuFgEUCOgtsgrpv3NBJMnEsjV3FNvk+2c1NiB Ot7k9OcmsRyCKYgix6G/YIszzJLwDqreN1AST/nSgrmtoXehksmFQE+zsYlSrdKjMx64 ook10HoBive0sFb1Owg8Xu58wctE+FceX90nb8tJ0RbgLDWLoAZV9m3F34S3wIjKFHn3 Ebjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=00PxBbfbrNZbkmqCqXfLs9yZ97MS3BWWQWlUZ8BdVkg=; b=o69n3radZdUnPwogYe+oCCdmjiLeECmBiIcfb7Z7dD6uds3PMstGFEYnUWMWm82GoX KZ+tmwnENIELWWL0q3Adr/qycsRW7NxXvPu8b2FjNbsWVODf0FljkP7GzVg4QnAWO7+b 7Uj81XaboRa0kjXs7w5z0D7M2JoT5x1IdVj44rvnUPrr5SGy06R7ldzUiVqQeoSpnT1R KyZvyBjh7ytVgFgvFk0dPZGklYRVweKKWbimfFW2T6AcTpUva1XDpWNCFH8GvG09DTSD YbEjgFbj+hdsYcrHFsturbjDVv93pn1yNjPPkdALUlcmCFXnuAJbPxzaBnfqGIbIs6ne C3Mg== X-Gm-Message-State: AOAM530ekRyrBlwrigKPooakUBhh0iAtVb6qC/cz/ntlv9Hb91LDARnt B9W+6QDGNe80X26JcuR35oO65vFLvjD3DbAQSBXgDA== X-Google-Smtp-Source: ABdhPJzUdKWuRdAPrylYz5y5O/axqRWdtUPsYH0N+t26hni9QvjzQlkzFTBuzmoVmtQU1vwaZ/l+DG9+nwXOUsdTzT4= X-Received: by 2002:a05:6402:42c9:: with SMTP id i9mr1167082edc.35.1619061177839; Wed, 21 Apr 2021 20:12:57 -0700 (PDT) MIME-Version: 1.0 References: <20210417175831.16413-1-jimw@sifive.com> <20210417175831.16413-4-jimw@sifive.com> In-Reply-To: From: Jim Wilson Date: Wed, 21 Apr 2021 20:12:46 -0700 Message-ID: Subject: Re: [PATCH 03/24] RISC-V sim: Atomic fixes. To: Jim Wilson , gdb-patches@sourceware.org, Kito Cheng X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Apr 2021 03:13:00 -0000 On Wed, Apr 21, 2021 at 5:09 PM Mike Frysinger wrote: > > Most of the other stuff is well tested just by running the gcc testsuite. > > imo, "just run the gcc testsuite" is not reasonable. it is extremely large > and slow and not conducive to iterative/fast development. it happening to > hit a bug sometimes depending on the current codegen behavior isn't the > same > as having good targetted logic. > I agree that the sim should have good testcases. It is only a question of how we get there. I'm stretched thin. If you want me to work on this, it will likely take a while. Meanwhile, the RISC-V sim won't be very useful until most of these patches get merged in. Some of the syscall stuff could just be dropped from this patch set if you don't like them, they aren't critical. Most of the rest is necessary to get a working simulator. my concern is that this becomes a convenient "we'll get to it later" and > then > later never comes. i'm not saying you don't have good intentions, but they > often don't last with real world pressures. the only carrot/leverage that > exists is not yet being merged. > > so maybe, maybe, you get a pass now, but this isn't the status quo moving > forward. > I'm helping maintain about 8 different software packages, 3 documents, and doing support on multiple mailing lists and social media channels for 3 organizations. So yes, there is risk that stuff may get delayed or dropped. But I've been doing GNU toolchain work for 34 years now, so I'm not going away tomorrow unless maybe I have a heart attack or something. And I'm hoping that more people start helping maintain this stuff as RISC-V gets more mainstream. Meanwhile, I'd much rather have a useful RISC-V sim upstream than the one we have now. I think others are more likely to help if we have a working simulator upstream. Also, part of the plan here is to kill off the github riscv/riscv-binutils-gdb tree to force people to work upstream. But that gets more complicated if riscv-binutils-gdb has a working simulator, and FSF gdb does not. These gdb sim patches are the only major non-ISA-extension work that hasn't been upstreamed yet. And we have separate plans for the ISA-extension work to put them on development branches in the FSF trees. Jim