On Sun, Mar 3, 2024 at 10:56 AM Eli Zaretskii <eliz@gnu.org> wrote:

> > From: Orgad Shaneh <orgads@gmail.com>
> > Cc: Orgad Shaneh <orgads@gmail.com>
> > Date: Sun,  3 Mar 2024 09:58:58 +0200
> >
> > From: Orgad Shaneh <orgads@gmail.com>
> >
> > Apply MSYS patches upstream.
>
> Thanks.  Please find a few comments below.
>

Thanks for the review.

But before that: what exactly is the MSYS target, and how does it
> differ from MinGW and Cygwin targets?
>

See https://www.msys2.org/docs/what-is-msys2/

It is based on Cygwin, but focuses on support for native Windows apps.

It also features a decent package manager, which Cygwin doesn't.

In addition, I think this warrants a NEWS entry (both for Binutils and
> for GDB).
>

Done.

> diff --git a/configure b/configure
> > index dd743c58663..51c7d7b0b20 100755
> > --- a/configure
> > +++ b/configure
> > @@ -1534,12 +1534,12 @@ Optional Features:
> >    --disable-FEATURE       do not include FEATURE (same as
> --enable-FEATURE=no)
> >    --enable-FEATURE[=ARG]  include FEATURE [ARG=yes]
> >    --enable-as-accelerator-for=ARG
> > -                          build as offload target compiler. Specify
> offload
> > +                          build as offload target compiler.
>  Specify offload
> >                            host triple by ARG
> >    --enable-offload-targets=LIST
> >                            enable offloading to devices from
> comma-separated
> > -                          LIST of TARGET[=DIR]. Use optional path to
> find
> > -                          offload target compiler during the build
> > +                          LIST of
>  TARGET[=DIR]. Use optional path to find
> > +                          offload target compiler
>  during the build
> >    --enable-offload-defaulted
>
> What are those ^M (CR) characters, here and elsewhere?  Looks like
> some artifact of the way you produced the diffs?
>

Looks like a bug in autoreconf on MSYS2. I reran it now on Linux.


> > @@ -4502,7 +4503,7 @@ cat confdefs.h - <<_ACEOF >conftest.$ac_ext
> >  /* end confdefs.h.  */
> >
> >  int
> > -main ()
> > +main (void)
> >  {
>
> Why is this needed?  Did you use some version of Autotools that
> produces these differences?
>

Possibly. Reverted now.

General comment: some of the sources patched in this series are
> maintained elsewhere: Readline is maintained by Bash, Libtool is
> maintained by its own project, etc.  So I expect you will need to
> submit the relevant parts to their upstream projects.
>

Ok, thanks.

- Orgad