From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23537 invoked by alias); 25 Jan 2018 10:04:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23526 invoked by uid 89); 25 Jan 2018 10:04:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=3.1 required=5.0 tests=BAYES_00,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=H*c:alternative X-HELO: mail-yb0-f174.google.com Received: from mail-yb0-f174.google.com (HELO mail-yb0-f174.google.com) (209.85.213.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 25 Jan 2018 10:04:20 +0000 Received: by mail-yb0-f174.google.com with SMTP id u35so2782898ybi.1 for ; Thu, 25 Jan 2018 02:04:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=WymJr8ORbp574m7QFvMEy9E56KkvfG4h5a1sARDKKt8=; b=nAuiArvB683qCYljAXLHdn+IzMMFnXts35cujrmUzEc3NRu1mNMIv3AxR3MQ5OFDPb /4Un3OelxzJBZG1fToCE53nQsX+E4jvYLCb+rg/7oNUQMQTBYOyvd51RZp3isX4rco+P gYFAU802ce3QjnfgcPs35XknGBGZ6KtrpIErP8iu2qUBLcaKAUd4Z6PZng1Gu8F8kCUv YlMR/1I4+oaA5VsdZ7lFRbQRNV3gW2bd/vLjezwX8YRdCNr6vm9vUmgBgytgw23iAMKb +XhYd+FxWkjTSMbgPVTiv/+Ggs7t8fY99XDkuwsviC1/3lvfij/RSnAMfmFN6AEaNJKY Yx7w== X-Gm-Message-State: AKwxytdiK7GtdHUB3whHe9ywYzZdRxcqj0ABaT7+RlKf85zvWzSD0V6R QblbzKT1F6ejXKOlDrzX7fxVbwmlFW7c2PeMH/9JURvWlnM= X-Google-Smtp-Source: AH8x226Qr54K0QjZ5HHhS5Oo/fpKod1kig/xjoKuz2zWh4s2S7Ye3kyYhwmoa+TijPw0ql0wPPEl2OYp+P4xog7fXFw= X-Received: by 10.37.177.135 with SMTP id h7mr8011892ybj.376.1516874658515; Thu, 25 Jan 2018 02:04:18 -0800 (PST) MIME-Version: 1.0 Received: by 10.37.203.210 with HTTP; Thu, 25 Jan 2018 02:03:58 -0800 (PST) In-Reply-To: <6c3f1fc7d56feaaa00ade76f51f7421f@polymtl.ca> References: <20180124165107.186980-1-leszeks@google.com> <6c3f1fc7d56feaaa00ade76f51f7421f@polymtl.ca> From: "Leszek Swirski via gdb-patches" Reply-To: Leszek Swirski Date: Thu, 25 Jan 2018 10:04:00 -0000 Message-ID: Subject: Re: [PATCH v2] Do not classify C struct members as a filename To: Simon Marchi Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2018-01/txt/msg00513.txt.bz2 > > I was able to reproduce the problem and confirmed that the patch fixes > it. I'm not very strong in the lexing/parsing area, but the change in > c-exp.y makes sense to me. I'd like to give others a chance to comment, so > let's wait a few days. If nobody answer, we can merge it. One nit, since > we are now using C++, can you use bool instead of int? It won't match the > old surrounding code, but that's a good reason to modernize the existing > code later :). > > Do you know if we have a test for the same thing, but with the "this" > pointer (which was already worked before this patch)? If not, it would be > nice to add it to the test as well. You could add a call to D::includefile > and continue/break there. From there, you could test calling > this->includefile(). Hi Simon, thanks for taking a look. Sure, I can update the tests (I'll add some tests for checking "c.includefile" while I'm at it) and change the int to a bool. I'm not 100% sure on the procedure here, do you want me to upload a v3 as a new thread? - Leszek