From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50218 invoked by alias); 26 May 2017 18:15:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11674 invoked by uid 89); 26 May 2017 18:15:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:2119 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-wr0-f194.google.com Received: from mail-wr0-f194.google.com (HELO mail-wr0-f194.google.com) (209.85.128.194) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 26 May 2017 18:15:17 +0000 Received: by mail-wr0-f194.google.com with SMTP id j27so1075114wre.2; Fri, 26 May 2017 11:15:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=puM4i+ZZPHTkU10zQqm24aUMBDQwEV/rTUrhGgrW51k=; b=LWtof2kSqsmOfIDfkQwyFvY+zhbEhFkVrbXeVZa9uQVSa8RrNVVKdjmMbYIYhsCP1R JVXMBaagoDjofswy+ycoG0bOzloXWMbYYfFeCAnaWIvIB9GTQUl+fX1VLJVbxxzh4WO/ xysPFevMn/1P+25Xy6rRoCXADX2gDZtAtDUh3erfcsZgIuasnX9dNsfTSavwR3wytxrs 5omXhtCXfMboTpBZWdpXjuW/BV00F4YMzuKZfCP2V/2/l6AqmgcmhOLXlTItNe0UGK0x CBXdZPVVG6FD6D0EKmYopoc20BjB+h9zjlou+a4+DRxox3cFWAsTZ7GTW0OjslC2zg3k zZFg== X-Gm-Message-State: AODbwcDsx0Pn5Umc8oTo7sS8wh7K6BtMspBKAeXnDhu7gHrULCBYnMKf +TB2SrmsSm+DQukNYwIVoZaAD4+Gkg== X-Received: by 10.223.166.143 with SMTP id t15mr2344643wrc.183.1495822511210; Fri, 26 May 2017 11:15:11 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.159.139 with HTTP; Fri, 26 May 2017 11:15:10 -0700 (PDT) In-Reply-To: References: <1495487553-19078-1-git-send-email-jcmvbkbc@gmail.com> <1495487553-19078-3-git-send-email-jcmvbkbc@gmail.com> From: "augustine.sterling@gmail.com" Date: Fri, 26 May 2017 18:15:00 -0000 Message-ID: Subject: Re: [RFC 2/5] xtensa: make configuration dynamic To: Max Filippov Cc: binutils@sourceware.org, gdb-patches@sourceware.org, David Weatherford , Maxim Grigoriev , Woody LaRue Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2017-05/txt/msg00575.txt.bz2 On Fri, May 26, 2017 at 11:10 AM, augustine.sterling@gmail.com wrote: > On Mon, May 22, 2017 at 2:12 PM, Max Filippov wrote: >> Now that XCHAL_* macros don't have to be preprocessor constants add >> include/xtensa-dynconfig.h that defines them as fields of a structure >> returned from the xtensa_get_config function. >> Define that structure and fill it with default parameter values >> specified in the include/xtensa-config.h. >> Define reusable function xtensa_load_config that tries to load >> configuration and return an address of an exported object from it. >> Define the function xtensa_get_config that uses xtensa_load_config to >> get structure xtensa_config, either dynamically configured or the >> default. >> >> 2017-05-22 Max Filippov >> bfd/ >> * Makefile.am (BFD32_BACKENDS, BFD32_BACKENDS_CFILES): Append >> xtensa-config.c. >> * Makefile.in: Regenerate. >> * configure: Regenerate. >> * configure.ac (xtensa_elf32_be_vec, xtensa_elf32_le_vec): Add >> xtensa-config.lo to the tb. >> * elf32-xtensa.c (xtensa-config.h): Replace #include with >> xtensa-dynconfig.h. >> * xtensa-config.c: New file. >> >> gas/ >> * config/tc-xtensa.c (xtensa-config.h): Replace #include with >> xtensa-dynconfig.h. >> * config/tc-xtensa.h: Likewise. >> * config/xtensa-relax.c: Likewise. >> >> include/ >> * xtensa-dynconfig.h: New file. >> >> ld/ >> * Makefile.am (eelf32xtensa.c): Add $(INCDIR)/xtensa-dynconfig.h >> to the list of dependencies. >> * Makefile.in: Regenerate. >> * emultempl/xtensaelf.em (xtensa-config.h): Replace #include >> with xtensa-dynconfig.h. > > This is ok. Actually, check that. I missed that this does both the refactoring necessary to add a plugin mechanism and actually adds the plugin mechanism. So: This introduces a plugin mechanism to gdb and binutils. That needs a higher-level discussion regarding licensing and plugin mechanisms generally, but from the general maintainers of both binutils and gdb. Would one of the general maintainers review this please?