From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30497 invoked by alias); 24 Oct 2016 22:53:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30461 invoked by uid 89); 24 Oct 2016 22:53:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1655, H*Ad:U*tom X-HELO: mail-qt0-f169.google.com Received: from mail-qt0-f169.google.com (HELO mail-qt0-f169.google.com) (209.85.216.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 24 Oct 2016 22:52:50 +0000 Received: by mail-qt0-f169.google.com with SMTP id r21so4786284qtr.4 for ; Mon, 24 Oct 2016 15:52:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=3IECxVUEpqAmrMFgQTgJC5I5xH8D11V453SNWKk+W/w=; b=QwzNvHShsQrcCRrKdemfCkwEExF9CwBLmkTls8Wy53Lo5ZsXQ7H3ToimmAcgOdXkef 380YqwRwODdyE0i5Xt4OWx9XQ6mSTmtEE2vY1dhkfB+XA7kLXcUy8Trq3TF6gEbYYA8m lPehTOGuBRq94vZNo/Fz3Gcw5RqufTWxLmnSq4LZ9JlDq+inKMHKDGzBOGSw/dWgB4VH lXomoljDOfhr1AWQdWf47EoBMj4CPQnSKUXRW413cCLOeDWCKCXhI3jFJo7obvKfPnff 3bjmJLt5N4Pa5kNlO3lA82EJm14FkibPPi8mfBF+gWcOoE30SviIy/5suYFBtRFnvZnC EvgA== X-Gm-Message-State: ABUngve/oQp2/b7rYTj4l60Tlh4Cz3Gs3gP1MH7Ol6TPkO9yEMPu34kK2RS4gFNiFoU0abTRMt+5a0ub1tFnnQ== X-Received: by 10.200.38.186 with SMTP id 55mr15683979qto.35.1477349569136; Mon, 24 Oct 2016 15:52:49 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.131.225 with HTTP; Mon, 24 Oct 2016 15:52:48 -0700 (PDT) In-Reply-To: References: From: David Edelsohn Date: Mon, 24 Oct 2016 22:53:00 -0000 Message-ID: Subject: Re: GDB AIX build broken To: Pedro Alves Cc: GDB Patches , Tom Tromey Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2016-10/txt/msg00676.txt.bz2 On Mon, Oct 24, 2016 at 6:46 PM, Pedro Alves wrote: > [fixed Tom's address] > > On 10/24/2016 11:40 PM, David Edelsohn wrote: >> GDB build on AIX is broken due to a recent commit. >> > > Which commit? Maybe the gnulib update? Is this a clean > build from scratch? I have no idea which commit. It probably was a bad idea to completely disrupt the GDB Buildbots while disruptively converting GDB to C++. > >> /home/dje/src/binutils-gdb/gdb/common/buffer.c >> /home/dje/src/binutils-gdb/gdb/common/buffer.c: In function 'void >> buffer_xml_printf(buffer*, const char*, ...)': >> /home/dje/src/binutils-gdb/gdb/common/buffer.c:133:27: error: expected >> ')' before 'PRId64' >> sprintf (str, "%" PRId64, >> ^~~~~~ > >> Errors with PRIxxx macros normally mean a problem with header file >> inclusion. for example, gdb/btrace.c, which also uses PRIxxx macros, >> builds without error. > > Sounds like what you'd get if PRId64 is not defined in that > compilation unit, somehow. First, strangely, gdb/common/buffer.c uses #include "inttypes.h" with quotes, not brackets. I can't find a local definition of that header file. It seems to be much happier with included first diff --git a/gdb/common/buffer.c b/gdb/common/buffer.c index e9eee09..a989024 100644 --- a/gdb/common/buffer.c +++ b/gdb/common/buffer.c @@ -17,10 +17,10 @@ You should have received a copy of the GNU General Public License along with this program. If not, see . */ +#include #include "common-defs.h" #include "xml-utils.h" #include "buffer.h" -#include "inttypes.h" Thanks, David