Re: [pushed] Define __STDC_CONSTANT_MACROS/__STDC_LIMIT_MACROS again (Re: GDB AIX build broken)

[David Edelsohn <dje.gcc@gmail.com>]

On Tue, Oct 25, 2016 at 6:57 AM, Pedro Alves <palves@redhat.com> wrote:
> On 10/25/2016 02:22 AM, Pedro Alves wrote:
>> On 10/25/2016 02:08 AM, David Edelsohn wrote:
>>> On Mon, Oct 24, 2016 at 8:50 PM, Pedro Alves <palves@redhat.com> wrote:
>>>> On 10/25/2016 01:31 AM, Pedro Alves wrote:
>>>>> On 10/25/2016 01:13 AM, David Edelsohn wrote:
>>>>>> On Mon, Oct 24, 2016 at 7:00 PM, Pedro Alves <palves@redhat.com> wrote:
>>>>>>
>>>>>>> That's a hint, but it can't be the fix.  common-defs.h must be the
>>>>>>> first file included.  I suspect that gnulib's inttypes.h
>>>>>>> replacement logic is broken on AIX.
>>>>>>
>>>>>> The gnulib import definitely is the commit that caused the breakage.
>>>>
>>>> Could it be it's the commit after the import?  The one
>>>> that removes __STDC_CONSTANT_MACROS/__STDC_LIMIT_MACROS from
>>>> common-defs.h?
>>>
>>> common-defs.h needs __STDC_FORMAT_MACROS defined before stdio.h is
>>> included, as one possible solution.
>>
>> I'll do this tomorrow.
>
> I've pushed the patch below to master.
>
> From 28fe4f87e0b815f4c0d9b80e0a9f3e6a53c649b3 Mon Sep 17 00:00:00 2001
> From: Pedro Alves <palves@redhat.com>
> Date: Tue, 25 Oct 2016 11:47:18 +0100
> Subject: [PATCH] Define __STDC_CONSTANT_MACROS/__STDC_LIMIT_MACROS again.
>
> Revert commit f6abaf7a4088 (gdb: no longer define
> __STDC_CONSTANT_MACROS/__STDC_LIMIT_MACROS), with the tweak suggested
> in that commit's log: the macros are now defined before any system
> header is included.
>
> This should fix AIX:
>   https://sourceware.org/ml/gdb-patches/2016-10/msg00682.html
>
> gdb/ChangeLog:
> 2016-10-25  Pedro Alves  <palves@redhat.com>
>
>        * common/common-defs.h (__STDC_CONSTANT_MACROS)
>        (__STDC_LIMIT_MACROS): Define.

Hi, Pedro

Thanks, however...

The missing macro is __STDC_FORMAT_MACROS.  The macros that you
re-added were not causing problems on AIX and don't enable the printf
format macros in C++.

Thanks, David