From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 52398 invoked by alias); 25 Oct 2016 12:41:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 52366 invoked by uid 89); 25 Oct 2016 12:41:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:2013 X-HELO: mail-qk0-f174.google.com Received: from mail-qk0-f174.google.com (HELO mail-qk0-f174.google.com) (209.85.220.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 25 Oct 2016 12:41:09 +0000 Received: by mail-qk0-f174.google.com with SMTP id z190so258185468qkc.2 for ; Tue, 25 Oct 2016 05:41:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=YoRy+FlDLIuTkv8Onj9UQBafmowBx+w3FcdxsqRMHoM=; b=FZe3I/qplOAZjb+BiMTfe8sIsc+IOckqpxa/WqYliiRyph96fDsEBkl4AwsHKqgqD9 hws/NDN0Qvhu1OJHnGAhP9OUHcZFcOCRFYKK8d1pI5NoE0kYuci63/HxFumpD+OFHpZY dtzuXfff++TZsE+GYxo9qTGruqy5XuiubqL1LusZovhJHkrPFLWW78MumRvqsM/rqk1S FfXd+1DxYEXePapve2Abrkce1lz5tXckv7aZk7DUNQcKY9oGwZU8bVH1gxfNsg/cST/G NiiQ4As1qr/Aad9POTmiRpJUUMiStoJrsmpSfHX8su5cfLK/ocWfdjV7kYVdcqgPZdj1 2BJw== X-Gm-Message-State: ABUngvfUOJtaqGYobFHlyzd/7FAJuB7NlvbcgAJZEeb5EdQ9oEqZcHpx6a8DKOTj1UooHQgDEpuRj5mmST6dWA== X-Received: by 10.55.203.9 with SMTP id d9mr21072831qkj.215.1477399268151; Tue, 25 Oct 2016 05:41:08 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.131.225 with HTTP; Tue, 25 Oct 2016 05:41:07 -0700 (PDT) In-Reply-To: <8fd35f0e-3a7e-25fb-f2ee-2fa50c35beff@redhat.com> References: <01ba546d-060d-8591-9c5a-84d4bda2af22@redhat.com> <9a7ac4b5-2f5c-916c-a52e-c94e64d6f4f0@redhat.com> <12052de4-a0dd-8d23-2f46-57e91059cfa5@redhat.com> <8fd35f0e-3a7e-25fb-f2ee-2fa50c35beff@redhat.com> From: David Edelsohn Date: Tue, 25 Oct 2016 12:41:00 -0000 Message-ID: Subject: Re: [pushed] Define __STDC_CONSTANT_MACROS/__STDC_LIMIT_MACROS again (Re: GDB AIX build broken) To: Pedro Alves Cc: GDB Patches Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2016-10/txt/msg00694.txt.bz2 On Tue, Oct 25, 2016 at 6:57 AM, Pedro Alves wrote: > On 10/25/2016 02:22 AM, Pedro Alves wrote: >> On 10/25/2016 02:08 AM, David Edelsohn wrote: >>> On Mon, Oct 24, 2016 at 8:50 PM, Pedro Alves wrote: >>>> On 10/25/2016 01:31 AM, Pedro Alves wrote: >>>>> On 10/25/2016 01:13 AM, David Edelsohn wrote: >>>>>> On Mon, Oct 24, 2016 at 7:00 PM, Pedro Alves wrote: >>>>>> >>>>>>> That's a hint, but it can't be the fix. common-defs.h must be the >>>>>>> first file included. I suspect that gnulib's inttypes.h >>>>>>> replacement logic is broken on AIX. >>>>>> >>>>>> The gnulib import definitely is the commit that caused the breakage. >>>> >>>> Could it be it's the commit after the import? The one >>>> that removes __STDC_CONSTANT_MACROS/__STDC_LIMIT_MACROS from >>>> common-defs.h? >>> >>> common-defs.h needs __STDC_FORMAT_MACROS defined before stdio.h is >>> included, as one possible solution. >> >> I'll do this tomorrow. > > I've pushed the patch below to master. > > From 28fe4f87e0b815f4c0d9b80e0a9f3e6a53c649b3 Mon Sep 17 00:00:00 2001 > From: Pedro Alves > Date: Tue, 25 Oct 2016 11:47:18 +0100 > Subject: [PATCH] Define __STDC_CONSTANT_MACROS/__STDC_LIMIT_MACROS again. > > Revert commit f6abaf7a4088 (gdb: no longer define > __STDC_CONSTANT_MACROS/__STDC_LIMIT_MACROS), with the tweak suggested > in that commit's log: the macros are now defined before any system > header is included. > > This should fix AIX: > https://sourceware.org/ml/gdb-patches/2016-10/msg00682.html > > gdb/ChangeLog: > 2016-10-25 Pedro Alves > > * common/common-defs.h (__STDC_CONSTANT_MACROS) > (__STDC_LIMIT_MACROS): Define. Hi, Pedro Thanks, however... The missing macro is __STDC_FORMAT_MACROS. The macros that you re-added were not causing problems on AIX and don't enable the printf format macros in C++. Thanks, David