public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: David Edelsohn <dje.gcc@gmail.com>
To: Pedro Alves <palves@redhat.com>
Cc: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: GDB AIX build broken
Date: Tue, 25 Oct 2016 00:13:00 -0000	[thread overview]
Message-ID: <CAGWvnymNjYyo9J-EQbU-XLkS4rHNZhyWbjF-cfZ+vxFAHk_B5A@mail.gmail.com> (raw)
In-Reply-To: <01ba546d-060d-8591-9c5a-84d4bda2af22@redhat.com>

On Mon, Oct 24, 2016 at 7:00 PM, Pedro Alves <palves@redhat.com> wrote:

> That's a hint, but it can't be the fix.  common-defs.h must be the
> first file included.  I suspect that gnulib's inttypes.h
> replacement logic is broken on AIX.

The gnulib import definitely is the commit that caused the breakage.

Interestingly,

gdb/btrace.c uses

#include <inttypes.h>

while

gdb/common/buffer.c uses

#include "inttypes.h"

Also, I'm sorry if my earlier comments came across poorly.

Thanks, David

  reply	other threads:[~2016-10-25  0:13 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-24 22:40 David Edelsohn
2016-10-24 22:46 ` Pedro Alves
2016-10-24 22:53   ` David Edelsohn
2016-10-24 23:00     ` Pedro Alves
2016-10-25  0:13       ` David Edelsohn [this message]
2016-10-25  0:31         ` Pedro Alves
2016-10-25  0:50           ` Pedro Alves
2016-10-25  1:08             ` David Edelsohn
2016-10-25  1:22               ` Pedro Alves
2016-10-25 10:58                 ` [pushed] Define __STDC_CONSTANT_MACROS/__STDC_LIMIT_MACROS again (Re: GDB AIX build broken) Pedro Alves
2016-10-25 12:41                   ` David Edelsohn
2016-10-25 12:48                     ` Pedro Alves
2016-10-25 12:54                       ` [pushed] common/common-defs.h: Define __STDC_FORMAT_MACROS as well " Pedro Alves
2016-10-25 13:01                         ` David Edelsohn
2016-10-25  0:51           ` GDB AIX build broken David Edelsohn
2016-10-25  1:10             ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGWvnymNjYyo9J-EQbU-XLkS4rHNZhyWbjF-cfZ+vxFAHk_B5A@mail.gmail.com \
    --to=dje.gcc@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).