From: David Edelsohn <dje.gcc@gmail.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Raunaq 12 <raunaq12@in.ibm.com>,
GDB Patches <gdb-patches@sourceware.org>,
Mark Kettenis <mark.kettenis@xs4all.nl>,
Ulrich Weigand <Ulrich.Weigand@de.ibm.com>
Subject: Re: [RFA/ppc-aix] fix thread support breakage (was: "Re: [PATCH 4/5] powerpc64-aix ptrace64 when defined.")
Date: Fri, 23 Aug 2013 07:23:00 -0000 [thread overview]
Message-ID: <CAGWvnymjyCc9vFbh4+eNdr2mdxJYU0=LFC1-itC38SDKfRaG-w@mail.gmail.com> (raw)
In-Reply-To: <20130823004837.GC5221@adacore.com>
On Thu, Aug 22, 2013 at 8:48 PM, Joel Brobecker <brobecker@adacore.com> wrote:
> Hello again,
>
>> Actually, I just found that it breaks thread support on 32bit AIX,
>> at least. A simpler way to show the problem is:
>>
>> (gdb) x /x &__n_pthreads
>> 0xf06a8258 <__n_pthreads>: Cannot access memory at address 0xf06a8258
>>
>> Prior to the patch, we have:
>>
>> (gdb) x /x &__n_pthreads
>> 0xf06a8258 <__n_pthreads>: 0x00000003
>
> Attached is the patch I checked in locally at AdaCore:
>
> gdb/ChangeLog:
>
> * rs6000-nat.c (rs6000_ptrace32): Cast "addr" to "uintptr_t"
> instead of "long long" in call to ptrace64.
>
> Tested on ppc-aix in full 32bit mode (both GDB and inferior are
> 32bit). I think the other scenario would be 64bit GDB debugging
> a 32bit inferior, but I don't have a 64bit compiler to try it.
>
> I'd like to commit this patch, unless there are comments/suggestions.
LGTM.
Is there a testcase that can be added to the GDB testsuite to catch
this type of regression?
Thanks, David
next prev parent reply other threads:[~2013-08-23 7:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAGWvnynVeLt6F-QREsP_CtQvwvtZgwqHxtcS6pn58LMf=AX=GA@mail.gmail.com>
2013-08-12 12:02 ` [PATCH 4/5] powerpc64-aix ptrace64 when defined Raunaq 12
2013-08-12 15:53 ` David Edelsohn
2013-08-12 12:11 ` Raunaq 12
2013-08-12 19:43 ` David Edelsohn
2013-08-22 23:32 ` Joel Brobecker
2013-08-23 0:48 ` [RFA/ppc-aix] fix thread support breakage (was: "Re: [PATCH 4/5] powerpc64-aix ptrace64 when defined.") Joel Brobecker
2013-08-23 7:23 ` David Edelsohn [this message]
2013-08-23 13:34 ` Joel Brobecker
2013-08-23 15:14 ` David Edelsohn
2013-09-10 10:16 ` Raunaq 12
2013-09-17 18:38 ` [RFA/ppc-aix] fix thread support breakage Tom Tromey
2013-08-29 21:03 ` Checked in: [RFA/ppc-aix] fix thread support breakage (was: "Re: [PATCH 4/5] powerpc64-aix ptrace64 when defined.") Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGWvnymjyCc9vFbh4+eNdr2mdxJYU0=LFC1-itC38SDKfRaG-w@mail.gmail.com' \
--to=dje.gcc@gmail.com \
--cc=Ulrich.Weigand@de.ibm.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
--cc=raunaq12@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).