From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24746 invoked by alias); 29 Sep 2014 22:29:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24736 invoked by uid 89); 29 Sep 2014 22:29:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ob0-f179.google.com Received: from mail-ob0-f179.google.com (HELO mail-ob0-f179.google.com) (209.85.214.179) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 29 Sep 2014 22:29:16 +0000 Received: by mail-ob0-f179.google.com with SMTP id wp4so519085obc.38 for ; Mon, 29 Sep 2014 15:29:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=6S5X4f3ULW7Zm3sP4zs+M35irnFRxdy5AXse59NJpT0=; b=dqyfpQs2l2QAnnJXbN9fXJ3GNSrdQaC9vjLNTN9Q5LDQvl9u3py/mRole6oPHV53Hx XglD6Y4sseRPTz3kqIcrhgawVOgd5DzIhVnLbjwcKDkOpMUOj6QugRlEPuo1n9otuhoQ GKz+TTfYSrTZGhqQ31JMTYLffjNzY1AD3EoMZLkG6eetTlIScexach1F1moH/qlw6crS xf0WFUVMsm/T0kUKfTP+Ev7yv2Ai8tEs/yd/gKk+puf5Pbw4G/ggrowGyAlbQ0DR4C2M F+QG/LFViCIf5EoaDJPsdtqU7u/dEshttd+AbWJbghT18k42sBBdfiqE4J0hGDwS9RSa cyNA== X-Gm-Message-State: ALoCoQkV9yqUaIOQ1DEe4b0gxRFTHfNTuEx5OY1tX0UNZtt9i4SlDIfmRKCw9x8kzSzeS0F9I19b MIME-Version: 1.0 X-Received: by 10.182.220.226 with SMTP id pz2mr5267776obc.76.1412029754586; Mon, 29 Sep 2014 15:29:14 -0700 (PDT) Received: by 10.202.225.135 with HTTP; Mon, 29 Sep 2014 15:29:14 -0700 (PDT) In-Reply-To: References: Date: Mon, 29 Sep 2014 22:29:00 -0000 Message-ID: Subject: Re: [PATCH 4/4] PR c++/13403 and PR c++/15154: Fix gnuv3_pass_by_reference to treat dynamic classes as non-trivial From: Siva Chandra To: Doug Evans Cc: gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-09/txt/msg00859.txt.bz2 On Mon, Sep 29, 2014 at 1:08 AM, Doug Evans wrote: >> 2014-09-11 Siva Chandra Reddy >> >> * gnu-v3-abi.c (gnuv3_pass_by_reference): Treat dynamic classes >> as non-trivial. > > This looks ok to me. > I couldn't find anything in the ABI to guide me (could certainly have > missed it), though it seems reasonable and it does fix the testcase. The ABI defers the definition of triviality of copy constructors and destructors to the C++ 98 final draft standard. The point under question in this patch is under -6- here: http://www.kouzdra.org/page/docs/isocpp/special.html#class.copy