From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13691 invoked by alias); 15 Oct 2014 12:03:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13680 invoked by uid 89); 15 Oct 2014 12:03:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-ob0-f177.google.com Received: from mail-ob0-f177.google.com (HELO mail-ob0-f177.google.com) (209.85.214.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 15 Oct 2014 12:03:55 +0000 Received: by mail-ob0-f177.google.com with SMTP id uy5so840802obc.22 for ; Wed, 15 Oct 2014 05:03:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=/neSX3Zj+T/eAE3L7l+wc+zVOKCxY4LlmKu+gYbTmNA=; b=B9KI01B7GRa/Ptwx5DQwg2d+dd2CVPzVC4ZJieo/HIV1df2nTwb4iDu8UqD1aW0gGH F9LehValMBOBNKtncMw1DuoPCqJvgUEF8lu0KxxgI9o+LKPNMlwz543huip/vs2ZD/Kt y/JDOEk+uA1MQg7wASU1ytHL3rXNkXPZN+7naFPfpMJKo6UfdDCWRH8ShwVX131OSN9V OOt7yI+9ML4hlb9iaXGgZzvJOcp/tORKsFGFB2bJbLh/0uLP8PgIVlJJZvO0xb/0+Oau xc5DTOMHPhyhVEFzDQJFlNH0n07BM+qxcqzUGtG6mewsqhEMbwlooppQeD0lI2rj0IWX MX2A== X-Gm-Message-State: ALoCoQnV1mk3CqQiOmQHkjOPD+/0hO/EUCDZEUf8ZUlZad+wIZLDngxySyHT/5H+dKdmQcxL8TWP MIME-Version: 1.0 X-Received: by 10.202.216.11 with SMTP id p11mr9725050oig.47.1413374633793; Wed, 15 Oct 2014 05:03:53 -0700 (PDT) Received: by 10.202.197.13 with HTTP; Wed, 15 Oct 2014 05:03:53 -0700 (PDT) In-Reply-To: References: Date: Wed, 15 Oct 2014 12:03:00 -0000 Message-ID: Subject: Re: [PATCH 0/4] PR c++/13403 and PR c++/15154: Fix function calling convention in gnuv3 ABI From: Siva Chandra To: Doug Evans Cc: gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg00385.txt.bz2 On Sun, Sep 28, 2014 at 9:12 PM, Doug Evans wrote: > On Thu, Sep 11, 2014 at 11:35 AM, Siva Chandra wrote: >> This patch series addresses the two listed PRs. The gnuv3 ABI function >> which decides whether a class value has to be passed by reference (or, >> returned in a hidden first parameter) is currently incomplete. This >> patch series completes it. >> >> The way I have organised my patches is that: >> >> - Patch 1/4 adds tests which illustrate what is missing. One test >> fails, another passes. >> - Patch 2/4 fixes the ABI to address the failing the test in 1/4. >> - Patch 3/4 adds another failing test. >> - Patch 4/4 fixes the ABI to address the failing test in 3/4. >> >> If the patches go in in the same order as above, then the tree will >> have one new failing test after 1/4 lands but before 2/4 lands. Is >> that OK? If not, then I can merge 1 and 2 into one patch, and 3 and 4 >> into 1 patch. I have ordered it this way because I thought it might be >> easier for the reviewers to see what works and what doesn't currently. > > That order is fine by me. Pushed the patch set. 778811d5e7eb96b5ecb848033ffaa2df455a921e 82c48ac732edb0155288a93ef3dd39625ff2d2e1 2d1c107c1b8835f4e85c35320d8595a4a6fcaebe ebb8ece2ef50ba3f86e8b4ab7a22a4c7734d114b