From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14782 invoked by alias); 29 Nov 2014 00:04:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14768 invoked by uid 89); 29 Nov 2014 00:04:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-ob0-f182.google.com Received: from mail-ob0-f182.google.com (HELO mail-ob0-f182.google.com) (209.85.214.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sat, 29 Nov 2014 00:03:59 +0000 Received: by mail-ob0-f182.google.com with SMTP id m8so5655364obr.27 for ; Fri, 28 Nov 2014 16:03:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=FtbvsYzWFpBrG0K5Ujc4BOPvGFyFV4Q0wDE1T4gfEfQ=; b=AIA5EGCgQCz0KjWvv+GoRzh/Ufa4os8iub/H85V0b6/ymIVW37x9CHu26ncUJmAXhn ObE9/Mx0i0OvuGXsd5HEOnTIV7cYGcCahC6aLfaihx+1/2O+8FgQFLDFmkyeEVaWdvfh GBRQVDzGog/vVK1Ji4JQluwELLoPP9efdFBePc0mmKdkB74ekk5okkeV8ZgSefQ7+LP+ mEBj8LIbWNrDaUOYoaAsz1Zw83XEzAionhmaD86GYJZUDi3K/Cb7foITOH1lTPbFz05f q+18H3PJXJWg1nMH+n91/P+3bRuoP75CBb70jUKb5uc7OSzezIg0ux1NancPErcSlW9i +k1w== X-Gm-Message-State: ALoCoQlZcJbz6PCtbByeJYPlTUzvAYoD8/8gwtpkhUSyFNAceksZqAsHrOtEaJt5sGvBJWygFIG0 MIME-Version: 1.0 X-Received: by 10.60.247.137 with SMTP id ye9mr19812942oec.35.1417219437070; Fri, 28 Nov 2014 16:03:57 -0800 (PST) Received: by 10.202.225.68 with HTTP; Fri, 28 Nov 2014 16:03:57 -0800 (PST) In-Reply-To: <201411281210.sASCAQGP013169@d03av02.boulder.ibm.com> References: <201411281210.sASCAQGP013169@d03av02.boulder.ibm.com> Date: Sat, 29 Nov 2014 00:04:00 -0000 Message-ID: Subject: Re: [PATCH v6] Make chained function calls in expressions work From: Siva Chandra To: Ulrich Weigand Cc: gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-11/txt/msg00724.txt.bz2 On Fri, Nov 28, 2014 at 4:10 AM, Ulrich Weigand wrote: > Siva Chandra wrote: > >> gdb/ChangeLog: >> >> 2014-11-27 Siva Chandra Reddy >> >> * eval.c: Include gdbthread.h. >> (evaluate_subexp): Enable thread stack temporaries before >> evaluating a complete expression and clean them up after the >> evaluation is complete. >> * gdbthread.h: Include common/vec.h. >> (value_ptr): New typedef. >> (VEC (value_ptr)): New vector type. >> (value_vec): New typedef. >> (struct thread_info): Add new fields stack_temporaries_enabled >> and stack_temporaries. >> (enable_thread_stack_temporaries) >> (thread_stack_temporaries_enabled_p, push_thread_stack_temporary) >> (get_last_thread_stack_temporary) >> (value_in_thread_stack_temporaries): Declare. >> * gdbtypes.c (class_or_union_p): New function. >> * gdbtypes.h (class_or_union_p): Declare. >> * infcall.c (call_function_by_hand): Store return values of class >> type as temporaries on stack. >> * thread.c (enable_thread_stack_temporaries): New function. >> (thread_stack_temporaries_enabled_p, push_thread_stack_temporary) >> (get_last_thread_stack_temporary): Likewise. >> (value_in_thread_stack_temporaries): Likewise. >> * value.c (value_force_lval): New function. >> * value.h (value_force_lval): Declare. >> >> gdb/testsuite/ChangeLog: >> >> 2014-11-27 Siva Chandra Reddy >> >> * gdb.cp/chained-calls.cc: New file. >> * gdb.cp/chained-calls.exp: New file. >> * gdb.cp/smartp.exp: Remove KFAIL for "p c2->inta". > > This is OK. > > Thanks for you patience in working through the many iterations on this patch! Thanks for your patience with explaining things to me. I have now pushed this patch after fixing the one comment: 6c659fc2c7cd2da6d2b9a3d7c38597ad3821832a