From: Siva Chandra <sivachandra@google.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 4/4] PR c++/13403 and PR c++/15154: Fix gnuv3_pass_by_reference to treat dynamic classes as non-trivial
Date: Wed, 15 Oct 2014 01:10:00 -0000 [thread overview]
Message-ID: <CAGyQ6gxxd58rrJ3aeFf2n-H9-623GYn67sojb875eYioHXBHsQ@mail.gmail.com> (raw)
In-Reply-To: <21565.36622.673293.934684@ruffy2.mtv.corp.google.com>
On Tue, Oct 14, 2014 at 2:01 PM, Doug Evans <dje@google.com> wrote:
> It'd be really nice to include a reference to the spec here.
> I don't know about others, but this stuff is not the kind of
> thing I tend to keep in cache, and when reading such code
> it's really nice to be able to find the relevant sections
> of the spec without any effort.
>
> Does the following make sense?
>
> + /* A dynamic class has a non-trivial copy constructor.
> + See c++98 section 12.8 Copying class objects [class.copy]. */
> + if (gnuv3_dynamic_class (type))
> + return 1;
> +
Thanks Doug. I will push this patch set after adding the above comment.
prev parent reply other threads:[~2014-10-15 1:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 18:38 Siva Chandra
2014-09-29 8:08 ` Doug Evans
2014-09-29 22:29 ` Siva Chandra
2014-10-14 21:01 ` Doug Evans
2014-10-15 1:10 ` Siva Chandra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGyQ6gxxd58rrJ3aeFf2n-H9-623GYn67sojb875eYioHXBHsQ@mail.gmail.com \
--to=sivachandra@google.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).