From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-116705-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 18167 invoked by alias); 15 Oct 2014 01:10:49 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 18007 invoked by uid 89); 15 Oct 2014 01:10:31 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-HELO: mail-ob0-f180.google.com
Received: from mail-ob0-f180.google.com (HELO mail-ob0-f180.google.com) (209.85.214.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 15 Oct 2014 01:10:29 +0000
Received: by mail-ob0-f180.google.com with SMTP id va2so204022obc.25        for <gdb-patches@sourceware.org>; Tue, 14 Oct 2014 18:10:26 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=1e100.net; s=20130820;        h=x-gm-message-state:mime-version:in-reply-to:references:date         :message-id:subject:from:to:cc:content-type;        bh=7dNqNSQ78ODPFUjLOP66Rb9BiaYTRvDCca17sX/x4mw=;        b=Foykk4AThuwh4IXXSHfAEKki4LT8EnJkovobX/B6CjNY5lFNRVKSZDczRaIn2WDKX7         IvLa0wyrYkXE9aIZPABrMGmypxVdSekn3HX1UmazRFIHCsUmasNALl9CZtPGi38Y3wT7         MQKYfU4mlzzQokYPO/9APtFO4Rc3EYKYC/5Qf115J4aeuzU/l/gWnhULoVUe2sWeSNFr         m226FRviSR25ejAgVGxuNCG6OFVvjFVPu+nAaAZI/yePjYLG5i61DP4hQSnwndh0nHqC         eVT2qzfav0y7SX4ODvJBfRMWMTjVyzotzmA4dDyHwm32nJavUQIymQ9FF9PNDqcBV6FX         f+BA==
X-Gm-Message-State: ALoCoQn9Wp5mPmGMTSyFlkCr0nRUV7OabeKPPXnt3PS5FE56iMRpHZazTQoZHHMTtHmFI96/Wqum
MIME-Version: 1.0
X-Received: by 10.60.63.79 with SMTP id e15mr7621968oes.31.1413335426672; Tue, 14 Oct 2014 18:10:26 -0700 (PDT)
Received: by 10.202.197.13 with HTTP; Tue, 14 Oct 2014 18:10:26 -0700 (PDT)
In-Reply-To: <21565.36622.673293.934684@ruffy2.mtv.corp.google.com>
References: <CAGyQ6gwUDdJh+oUxJxhgSXfY90cp2hkh-+mN0wEcJp90naBXog@mail.gmail.com>	<CADPb22Q6KH+i=Jwho3B2a-DACjYFrgFby0uG0LEnfOi3d=9HZg@mail.gmail.com>	<CAGyQ6gw+4OZgoaj3P+Nv+wjTKqCtde_zZ9nP9qDLfd4wxFsYpA@mail.gmail.com>	<21565.36622.673293.934684@ruffy2.mtv.corp.google.com>
Date: Wed, 15 Oct 2014 01:10:00 -0000
Message-ID: <CAGyQ6gxxd58rrJ3aeFf2n-H9-623GYn67sojb875eYioHXBHsQ@mail.gmail.com>
Subject: Re: [PATCH 4/4] PR c++/13403 and PR c++/15154: Fix gnuv3_pass_by_reference to treat dynamic classes as non-trivial
From: Siva Chandra <sivachandra@google.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2014-10/txt/msg00381.txt.bz2

On Tue, Oct 14, 2014 at 2:01 PM, Doug Evans <dje@google.com> wrote:
> It'd be really nice to include a reference to the spec here.
> I don't know about others, but this stuff is not the kind of
> thing I tend to keep in cache, and when reading such code
> it's really nice to be able to find the relevant sections
> of the spec without any effort.
>
> Does the following make sense?
>
> +  /* A dynamic class has a non-trivial copy constructor.
> +     See c++98 section 12.8 Copying class objects [class.copy].  */
> +  if (gnuv3_dynamic_class (type))
> +    return 1;
> +

Thanks Doug. I will push this patch set after adding the above comment.