From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24921 invoked by alias); 18 Jun 2014 14:03:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24903 invoked by uid 89); 18 Jun 2014 14:03:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-oa0-f53.google.com Received: from mail-oa0-f53.google.com (HELO mail-oa0-f53.google.com) (209.85.219.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 18 Jun 2014 14:03:27 +0000 Received: by mail-oa0-f53.google.com with SMTP id l6so1869628oag.40 for ; Wed, 18 Jun 2014 07:03:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=2l33PblJGu6vH9y1tFNtFaikg7qF0l74iZSA45X5Im8=; b=kw4DeYFHrbVWFCJXc34GnUyBtgEtIS6GPge3bOqvJle1wRXUPc0vlmyk1Yq5aAkGQI rJLmvxvdupJ+nRgO7gjRxKM/yO9VehoA+JG7aNcKEuaTPA3a/fOl8jJJ1HV9WLEXfRqk 0GAd3UrJm0tiR7VHyrHCi+w1OGXV95q07mzQZlabENfoq83ujlSdQy2PI1HW5//egvqd 2mDtSSfNMJWDgO9xazkRr3zfgVWZowMR+mDNEHTt12qqLr0+w5IcWEKLkZDsQI9AtS65 5MH6X8QL4nupRCyVD7f4OF62aPk2ymqwmKvLBTXKgxG7oTzvqZDwBZTVp4ePHgEdmjiv egUQ== X-Gm-Message-State: ALoCoQlFbj/9x/ZkM+TVhzMi4Ss3re1wjhFcmBL2OBABvdpW+uSdaA49fIsNwzsvOyKyofkOY1Q3 MIME-Version: 1.0 X-Received: by 10.182.153.33 with SMTP id vd1mr2184417obb.86.1403100205982; Wed, 18 Jun 2014 07:03:25 -0700 (PDT) Received: by 10.202.187.198 with HTTP; Wed, 18 Jun 2014 07:03:25 -0700 (PDT) In-Reply-To: <53A19A53.6030107@redhat.com> References: <1403014378-4349-1-git-send-email-gbenson@redhat.com> <1403014378-4349-12-git-send-email-gbenson@redhat.com> <20140618132832.GA6225@blade.nx> <53A19A53.6030107@redhat.com> Date: Wed, 18 Jun 2014 14:03:00 -0000 Message-ID: Subject: Re: [PATCH 11/15] Rename functions and make nonstatic as necessary From: Siva Chandra To: Pedro Alves Cc: Gary Benson , gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-06/txt/msg00658.txt.bz2 On Wed, Jun 18, 2014 at 6:55 AM, Pedro Alves wrote: > On 06/18/2014 02:28 PM, Gary Benson wrote: >> Siva Chandra wrote: >>> On Tue, Jun 17, 2014 at 7:12 AM, Gary Benson wrote: >>>> This commit renames the functions that are to be shared. >>>> Functions to be shared that were static are made nonstatic. >>> >>> I thinking making the functions nonstatic in this part was not >>> correct. The build currently fails when built with >>> "-Werror=missing-prototypes" as 14/15 has not yet been committed. >> >> My apologies Siva. >> >> Pedro, should I commit the remaining piece now, and work on the >> i386_insert_hw_breakpoint as a separate patch? > > As you've committed the header patch already, I think the issue > is actually already fixed? Yes, I just checked; the issue is already fixed.