From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-116427-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 807 invoked by alias); 6 Oct 2014 21:20:23 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 796 invoked by uid 89); 6 Oct 2014 21:20:22 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-HELO: mail-ob0-f178.google.com
Received: from mail-ob0-f178.google.com (HELO mail-ob0-f178.google.com) (209.85.214.178) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 06 Oct 2014 21:20:21 +0000
Received: by mail-ob0-f178.google.com with SMTP id wn1so4632861obc.23        for <gdb-patches@sourceware.org>; Mon, 06 Oct 2014 14:20:19 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=1e100.net; s=20130820;        h=x-gm-message-state:mime-version:in-reply-to:references:date         :message-id:subject:from:to:cc:content-type;        bh=y9W5flhDoQD9XZRyl0qtHNm4K2ct3KnBsWqrA4sXXrM=;        b=KOKm1lLpZmXwL/qj6VUSE1nKxnLhJYKPm6WCwcxFYGuMDyYxPfY3+kn2tLPu7zrRdf         XSambY/k7bG+9H6p6tO6paHidWsspdnXZB5retR10j7zXWYQr4JO9u6JiyokqHJwOifU         rEmnwDDtTtzF6x/8wIaks2XmZUkH/EyL9jgbxNVwy0wEzEyAmmM+zNoC91oTX3Gz9/p5         EJF2J+7lB73l7b43bvR3pRyMSOYpEcFcQTMSWtTrSsRcCleAPYB2ODREZb3nY81H5oJg         0n9eAX/ZHn89XPX1+HRWJWsdRlnv51EKvisDX7w0oCbEP6j1peO+hNB4qpqfxaTXP68Y         L1og==
X-Gm-Message-State: ALoCoQnYQOch/ca7aNDeUD9pbbdfYmc8K/N5EvM/SbFMK+BrpM8FvG+bK10XVbxPjBHzPQekjvtZ
MIME-Version: 1.0
X-Received: by 10.60.65.35 with SMTP id u3mr30906047oes.35.1412630419779; Mon, 06 Oct 2014 14:20:19 -0700 (PDT)
Received: by 10.202.197.13 with HTTP; Mon, 6 Oct 2014 14:20:19 -0700 (PDT)
In-Reply-To: <CAGyQ6gxdno4x2dxQ==-d3A4UxRGJjE18y-xPAdLWqxA06cgQhw@mail.gmail.com>
References: <CAGyQ6gzqbyL-ushbTo9u0iccvmhJnekwa8EDxdL3xCJMkGcEYQ@mail.gmail.com>	<CADPb22RoEi+AKN+==ZcK-K8MR80gvVje7iaHT7ThMQJ9ibmKWA@mail.gmail.com>	<CAGyQ6gxdno4x2dxQ==-d3A4UxRGJjE18y-xPAdLWqxA06cgQhw@mail.gmail.com>
Date: Mon, 06 Oct 2014 21:20:00 -0000
Message-ID: <CAGyQ6gyP0E_7_fK5TNxKB4NtYYLiUwK1uTkAoNjkkR6CkvzygA@mail.gmail.com>
Subject: Re: [PATCH 2/4] PR c++/13403 and PR c++/15154: Fix gnuv3_pass_by_reference to lookup copy c-tors with qualified args
From: Siva Chandra <sivachandra@google.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2014-10/txt/msg00103.txt.bz2

On Mon, Sep 29, 2014 at 2:11 PM, Siva Chandra <sivachandra@google.com> wrote:
> On Sun, Sep 28, 2014 at 11:01 PM, Doug Evans <dje@google.com> wrote:
>>> 2014-09-11  Siva Chandra Reddy  <sivachandra@google.com>
>>>
>>>         PR c++/13403
>>>         PR c++/15154
>>>         * gdbtypes.c (make_qualified_type): Make non-static.
>>>         * gdbtypes.h (make_qualified_type): Declare.
>>>         * gnu-v3-abi.c (gnuv3_pass_by_reference): Lookup copy
>>>         constructors with qualified args
>
>> Can you use class_types_same_p here (instead of comparing with the
>> result of make_qualified_type) ?
>
> Yes, I made this change now. The patch is attached.
>
> I am assuming that the other patches in this series are approved
> modulo making the test regexes more specific.
>
>  gdb/ChangeLog:
>
> 2014-09-29  Siva Chandra Reddy  <sivachandra@google.com>
>
>         PR c++/13403
>         PR c++/15154
>         * gnu-v3-abi.c (gnuv3_pass_by_reference): Lookup copy constructors
>         with qualified args.

Ping.