From: Siva Chandra <sivachandra@google.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/4] PR c++/13403 and PR c++/15154: Fix gnuv3_pass_by_reference to lookup copy c-tors with qualified args
Date: Tue, 14 Oct 2014 14:12:00 -0000 [thread overview]
Message-ID: <CAGyQ6gz9D6PfzYshWTuTz3xvy=Cv=X2rcSjEaoywfS7ZOsAFDQ@mail.gmail.com> (raw)
In-Reply-To: <CAGyQ6gxdno4x2dxQ==-d3A4UxRGJjE18y-xPAdLWqxA06cgQhw@mail.gmail.com>
On Mon, Sep 29, 2014 at 2:11 PM, Siva Chandra <sivachandra@google.com> wrote:
> On Sun, Sep 28, 2014 at 11:01 PM, Doug Evans <dje@google.com> wrote:
>>> * gnu-v3-abi.c (gnuv3_pass_by_reference): Lookup copy
>>> constructors with qualified args
>
>> Can you use class_types_same_p here (instead of comparing with the
>> result of make_qualified_type) ?
>
> Yes, I made this change now. The patch is attached.
>
> I am assuming that the other patches in this series are approved
> modulo making the test regexes more specific.
>
> gdb/ChangeLog:
>
> 2014-09-29 Siva Chandra Reddy <sivachandra@google.com>
>
> PR c++/13403
> PR c++/15154
> * gnu-v3-abi.c (gnuv3_pass_by_reference): Lookup copy constructors
> with qualified args.
Ping. Link: https://sourceware.org/ml/gdb-patches/2014-09/msg00854.html
next prev parent reply other threads:[~2014-10-14 14:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 18:37 Siva Chandra
2014-09-29 6:01 ` Doug Evans
2014-09-29 21:11 ` Siva Chandra
2014-10-06 21:20 ` Siva Chandra
2014-10-14 14:12 ` Siva Chandra [this message]
2014-10-14 21:03 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGyQ6gz9D6PfzYshWTuTz3xvy=Cv=X2rcSjEaoywfS7ZOsAFDQ@mail.gmail.com' \
--to=sivachandra@google.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).