From: Yao Qi <qiyaoltc@gmail.com>
To: Pedro Alves <palves@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] [GDBserver] Replace "reinsert_breakpoint" with "singlestep_breakpoint"
Date: Fri, 02 Sep 2016 14:53:00 -0000 [thread overview]
Message-ID: <CAH=s-PM1XjLC8Z7iq9iXJF_W_UHLorOsg9kpm080=0SJkPTQeg@mail.gmail.com> (raw)
In-Reply-To: <08a52e9b-38fe-4164-bfbe-de7edf7630ce@redhat.com>
On Fri, Sep 2, 2016 at 11:24 AM, Pedro Alves <palves@redhat.com> wrote:
>>
>> /* A basic-software-single-step breakpoint. */
>> - reinsert_breakpoint,
>> + single_step_breakpoint,
>
> Can you drop the "basic" while at it? Made some sense
> when this was only used for the return address of
> nptl's magic thread event breakpoint functions, but it no
> longer does.
>
OK, "basic-" is removed. Patch is pushed in.
--
Yao (齐尧)
prev parent reply other threads:[~2016-09-02 14:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-01 9:01 Yao Qi
2016-09-01 16:18 ` Pedro Alves
2016-09-02 8:05 ` Yao Qi
2016-09-02 10:24 ` Pedro Alves
2016-09-02 14:53 ` Yao Qi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH=s-PM1XjLC8Z7iq9iXJF_W_UHLorOsg9kpm080=0SJkPTQeg@mail.gmail.com' \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).