From: Yao Qi <qiyaoltc@gmail.com>
To: Andrew Pinski <apinski@cavium.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
binutils@sourceware.org
Subject: Re: [PATCH 2/3] Add ILP32 support to gdb.
Date: Thu, 01 Sep 2016 13:13:00 -0000 [thread overview]
Message-ID: <CAH=s-PM9JxPJhoVj9WKOWsZ-RF--3EAX66RTH_Z1LbEvZBqQMw@mail.gmail.com> (raw)
In-Reply-To: <1472715400-43043-3-git-send-email-apinski@cavium.com>
On Thu, Sep 1, 2016 at 8:36 AM, Andrew Pinski <apinski@cavium.com> wrote:
> This patch adds AARCH64:ilp32 support to gdb and sets
> up the correct sizes for some types like pointers and long.
> Also sets up the correct linker map offsets for Linux.
>
> 2016-08-31 Andrew Pinski <apinski@cavium.com>
>
> * aarch64-tdep.h (gdbarch_tdep): Add ilp32 field.
It should be * aarch64-tdep.h (gdbarch_tdep) <ilp32>: New field.
> * aarch64-tdep.c (aarch64_gdbarch_init): Setup ILP32 support.
> Make sure the gdbarches have compatible ilp32 flags.
> Set long and ptr sizes correctly for ilp32.
> * aarch64-linux-tdep.c (aarch64_linux_init_abi):
> Add support for ILP32.
> diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c
> index 3b7e954..1730ef8 100644
> --- a/gdb/aarch64-tdep.c
> +++ b/gdb/aarch64-tdep.c
> @@ -2646,6 +2646,12 @@ aarch64_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
> const struct tdesc_feature *feature;
> int num_regs = 0;
> int num_pseudo_regs = 0;
> + char ilp32 = FALSE;
s/char/int/
> +
> + if (info.abfd
> + && bfd_get_flavour (info.abfd) == bfd_target_elf_flavour
> + && elf_elfheader (info.abfd)->e_ident[EI_CLASS] == ELFCLASS32)
> + ilp32 = TRUE;
How about this?
if (info.bfd_arch_info->mach == bfd_mach_aarch64_ilp32)
ilp32 = TRUE;
> --- a/gdb/aarch64-tdep.h
> +++ b/gdb/aarch64-tdep.h
> @@ -95,6 +95,9 @@ struct gdbarch_tdep
>
> /* syscall record. */
> int (*aarch64_syscall_record) (struct regcache *regcache, unsigned long svc_number);
> + /* If this is ILP32 or LP64. */
> + bool ilp32;
We don't use bool in GDB, use int instead.
--
Yao (齐尧)
next prev parent reply other threads:[~2016-09-01 13:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 0:26 [PATCH 0/3] Support AARCH64 ILP32 for gdb Andrew Pinski
2016-08-30 0:26 ` [PATCH 1/3] Move AARCH64 ILP32 rejection handling Andrew Pinski
2016-08-30 0:26 ` [PATCH 2/3] Add ILP32 support to gdb Andrew Pinski
2016-08-30 7:44 ` Andreas Schwab
2016-09-01 4:21 ` Andrew Pinski
2016-09-01 7:41 ` Andreas Schwab
2016-08-30 0:26 ` [PATCH 3/3] Handle ILP32 AARCH64 correctly for gdbserver Andrew Pinski
2016-08-30 8:01 ` Andreas Schwab
2016-08-31 10:42 ` Pedro Alves
2016-08-31 12:58 ` Yao Qi
2016-08-31 20:02 ` Andrew Pinski
2016-09-01 7:37 ` [PATCH v2 0/3] Support AARCH64 ILP32 for gdb Andrew Pinski
2016-09-01 7:36 ` [PATCH 2/3] Add ILP32 support to gdb Andrew Pinski
2016-09-01 9:50 ` Andreas Schwab
2016-09-01 13:13 ` Yao Qi [this message]
2016-09-01 7:37 ` [PATCH 1/3] Move AARCH64 ILP32 rejection handling Andrew Pinski
2016-09-01 9:43 ` Richard Earnshaw (lists)
2016-09-01 7:37 ` [PATCH 3/3] Handle ILP32 AARCH64 correctly for gdbserver Andrew Pinski
2016-09-01 8:32 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH=s-PM9JxPJhoVj9WKOWsZ-RF--3EAX66RTH_Z1LbEvZBqQMw@mail.gmail.com' \
--to=qiyaoltc@gmail.com \
--cc=apinski@cavium.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).