From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 108269 invoked by alias); 1 Sep 2016 13:13:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 108242 invoked by uid 89); 1 Sep 2016 13:13:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-oi0-f68.google.com Received: from mail-oi0-f68.google.com (HELO mail-oi0-f68.google.com) (209.85.218.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 01 Sep 2016 13:13:44 +0000 Received: by mail-oi0-f68.google.com with SMTP id 2so1550444oif.2; Thu, 01 Sep 2016 06:13:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=c97pGtmIQ0TcFfontUNUfO8lElGPnFxOP8/XO/6FcNU=; b=a/1fdi0bLXdJE1UVx2/JaDqYZNOkpxX59RzkgnphmfBartTgTz12Ul4Wskfv2EzhGz tTaCSy7s3l3nbGnCWoCnMPLh4xdnJyuBZx4T3cHnWd1yrq/GuvOC8Fc6n0CTN8+cr46n dR1Crxr94WWzgtHZ7M3ho4Ap/nRP8sv8+IA290DHEbLi/E0pg0QH4AA5L95eB+Kzd3XB bCi67Lv+6PiNwkxsPq+Jqon1c8nH/e9a6vAbUqIwV6gkka+9XnSpbk4MVXXzdDnwR3ls jqVLUZdc7suTAOS8EXt85kNM/H4DVDws60boowLAAkSwvm/Kn0hX3OTBUAilNK66pvjq AqiA== X-Gm-Message-State: AE9vXwO3MzFDYd0kYBWY94pXDg2GnfIDhoPgjtqW7HHzZpGUNZuWY4GUecIUdtCEm2hgZTP4Ban8JRGEDemteA== X-Received: by 10.202.7.5 with SMTP id 5mr15015476oih.115.1472735623179; Thu, 01 Sep 2016 06:13:43 -0700 (PDT) MIME-Version: 1.0 Received: by 10.202.79.201 with HTTP; Thu, 1 Sep 2016 06:13:42 -0700 (PDT) In-Reply-To: <1472715400-43043-3-git-send-email-apinski@cavium.com> References: <1472516750-30743-1-git-send-email-apinski@cavium.com> <1472715400-43043-1-git-send-email-apinski@cavium.com> <1472715400-43043-3-git-send-email-apinski@cavium.com> From: Yao Qi Date: Thu, 01 Sep 2016 13:13:00 -0000 Message-ID: Subject: Re: [PATCH 2/3] Add ILP32 support to gdb. To: Andrew Pinski Cc: "gdb-patches@sourceware.org" , binutils@sourceware.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-09/txt/msg00015.txt.bz2 On Thu, Sep 1, 2016 at 8:36 AM, Andrew Pinski wrote: > This patch adds AARCH64:ilp32 support to gdb and sets > up the correct sizes for some types like pointers and long. > Also sets up the correct linker map offsets for Linux. > > 2016-08-31 Andrew Pinski > > * aarch64-tdep.h (gdbarch_tdep): Add ilp32 field. It should be * aarch64-tdep.h (gdbarch_tdep) : New field. > * aarch64-tdep.c (aarch64_gdbarch_init): Setup ILP32 support. > Make sure the gdbarches have compatible ilp32 flags. > Set long and ptr sizes correctly for ilp32. > * aarch64-linux-tdep.c (aarch64_linux_init_abi): > Add support for ILP32. > diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c > index 3b7e954..1730ef8 100644 > --- a/gdb/aarch64-tdep.c > +++ b/gdb/aarch64-tdep.c > @@ -2646,6 +2646,12 @@ aarch64_gdbarch_init (struct gdbarch_info info, st= ruct gdbarch_list *arches) > const struct tdesc_feature *feature; > int num_regs =3D 0; > int num_pseudo_regs =3D 0; > + char ilp32 =3D FALSE; s/char/int/ > + > + if (info.abfd > + && bfd_get_flavour (info.abfd) =3D=3D bfd_target_elf_flavour > + && elf_elfheader (info.abfd)->e_ident[EI_CLASS] =3D=3D ELFCLASS32) > + ilp32 =3D TRUE; How about this? if (info.bfd_arch_info->mach =3D=3D bfd_mach_aarch64_ilp32) ilp32 =3D TRUE; > --- a/gdb/aarch64-tdep.h > +++ b/gdb/aarch64-tdep.h > @@ -95,6 +95,9 @@ struct gdbarch_tdep > > /* syscall record. */ > int (*aarch64_syscall_record) (struct regcache *regcache, unsigned lon= g svc_number); > + /* If this is ILP32 or LP64. */ > + bool ilp32; We don't use bool in GDB, use int instead. --=20 Yao (=E9=BD=90=E5=B0=A7)