From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44948 invoked by alias); 22 Jan 2018 14:58:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 44129 invoked by uid 89); 22 Jan 2018 14:58:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1102, H*f:sk:ace5c32, H*i:sk:ace5c32 X-HELO: mail-qt0-f180.google.com Received: from mail-qt0-f180.google.com (HELO mail-qt0-f180.google.com) (209.85.216.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 22 Jan 2018 14:58:21 +0000 Received: by mail-qt0-f180.google.com with SMTP id c2so21390896qtn.9 for ; Mon, 22 Jan 2018 06:58:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=kUaNAk2RHx+TE5xopiMUA9d9QR24IU+kWdn6NnGghRE=; b=n2GAoAb2JRSFJnSErt9Isq8dCV04DcjnK4W9I44AoLzWd25wYSyDw+5CQomcsSQNL0 LDzipwWC0uMLqLfj5zNTwWxEbgMDmmpS/kNj16AmsyD5rSbVYyyCO2nNiSmy+PiSgMjn 7M1gzHDI6p99qfmw9B2u2a6IhmeA5mTKhIBsL5z6J9tbIo+8EKTJDJ6H558hLKa3AuVc /RM4S+5bRgYx0oKI2AcZXf2HvBL8cFHMx6DBrmMV9W0OZFwfmF8i+OPYrPlePt3T08bC F9RlKg0LvE16Lb3m7MCDFFcFIrGoFR/iLUkpjLt0tg/6xE3V0ksOei3OUSNzIIm21MGs R/ig== X-Gm-Message-State: AKwxytcqNkyR0ysLAevg3TzL1wQ6v/ShCBfm2CYBXhSXFWAmS6SjmOim u9PZ9SJ3wLHHYxiEpiD1Ux/5//epVQB0/WFds/g= X-Google-Smtp-Source: AH8x224WsOnX9CMhW0pj9afBqHf2c9WaWJwidFVGl5ZCUYzoQF7IOlbSyt0UyVkiPSdB62dvUgWu7FKTl0cTrqKjFjo= X-Received: by 10.200.67.75 with SMTP id a11mr11648180qtn.197.1516633100278; Mon, 22 Jan 2018 06:58:20 -0800 (PST) MIME-Version: 1.0 Received: by 10.12.153.232 with HTTP; Mon, 22 Jan 2018 06:58:19 -0800 (PST) In-Reply-To: References: <1512125286-29788-1-git-send-email-yao.qi@linaro.org> <86fu75g4l5.fsf@gmail.com> From: Yao Qi Date: Mon, 22 Jan 2018 14:58:00 -0000 Message-ID: Subject: Re: [RFC 00/15] Remove regcache::m_readonly_p To: Simon Marchi Cc: GDB Patches Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2018-01/txt/msg00444.txt.bz2 On Thu, Jan 18, 2018 at 4:56 PM, Simon Marchi w= rote: > > Which of these types will have actual instances of them, and which ones > are only interfaces? > reg_buffer_rw, regcache_readonly and regcache have instances. regcache_read is abstract. reg_buffer is not abstract, but it has no instances. > I have some problem understanding the difference between regcache_read > and regcache_readonly. I think the fact that the name is so similar > doesn't help. Would there be a better name for regcache_readonly? regcache_readonly is a type used when the instance of regcache is readonly. regcache_readonly extends regcache_read, and implement virtual function raw_update doing nothing. regcache_read is an abstract class, in which raw_update is a pure virtual function. It only has methods to do the read. I pushed them to branch users/qiyao/regcache-split-4-1 I also generate doxygen doc http://people.linaro.org/~yao.qi/gdb/doxy/regcache-split-4/doxy/gdb-xref/cl= assreg__buffer.html I am open to the naming. --=20 Yao (=E9=BD=90=E5=B0=A7)