* [PATCH] Fix gdb.base/attach.exp fails when gdb is configured --with-sysroot=/
@ 2018-01-24 15:52 Yao Qi
2018-01-24 16:03 ` Andreas Schwab
0 siblings, 1 reply; 4+ messages in thread
From: Yao Qi @ 2018-01-24 15:52 UTC (permalink / raw)
To: gdb-patches
I see some test fails in gdb.base/attach.exp when gdb is configured
--with-sysroot=/.
FAIL: gdb.base/attach.exp: attach2, with no file
FAIL: gdb.base/attach.exp: load file manually, after attach2 (re-read) (got interactive prompt)
FAIL: gdb.base/attach.exp: attach when process' a.out not in cwd
If gdb is configured this way, sysroot is "/" in default, and if binfile
is a absolute path, the regexp pattern $sysroot$escapedbinfile is
incorrect.
There are different ways to fix it, but I don't want to complicate the
test, so I choose this naive way.
gdb/testsuite:
2018-01-24 Yao Qi <yao.qi@linaro.org>
* gdb.base/attach.exp (do_attach_tests): Set sysroot to ".*".
---
gdb/testsuite/gdb.base/attach.exp | 15 ++++++---------
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/gdb/testsuite/gdb.base/attach.exp b/gdb/testsuite/gdb.base/attach.exp
index d315c27..c30e95d 100644
--- a/gdb/testsuite/gdb.base/attach.exp
+++ b/gdb/testsuite/gdb.base/attach.exp
@@ -57,15 +57,12 @@ proc do_attach_tests {} {
# Figure out a regular expression that will match the sysroot,
# noting that the default sysroot is "target:", and also noting
# that GDB will strip "target:" from the start of filenames when
- # operating on the local filesystem
- set sysroot ""
- set test "show sysroot"
- gdb_test_multiple $test $test {
- -re "The current system root is \"(.*)\"\..*${gdb_prompt} $" {
- set sysroot $expect_out(1,string)
- }
- }
- regsub "^target:" "$sysroot" "(target:)?" sysroot
+ # operating on the local filesystem. However the default sysroot
+ # can be set via configure option --with-sysroot, which can be "/".
+ # If $binfile is a absolute path, so pattern
+ # "$sysroot$escapedbinfile" below is wrong. Use .* to make
+ # $sysroot simple.
+ set sysroot ".*"
# Start the program running and then wait for a bit, to be sure
# that it can be attached to.
--
1.9.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix gdb.base/attach.exp fails when gdb is configured --with-sysroot=/
2018-01-24 15:52 [PATCH] Fix gdb.base/attach.exp fails when gdb is configured --with-sysroot=/ Yao Qi
@ 2018-01-24 16:03 ` Andreas Schwab
2018-01-24 16:12 ` Yao Qi
0 siblings, 1 reply; 4+ messages in thread
From: Andreas Schwab @ 2018-01-24 16:03 UTC (permalink / raw)
To: Yao Qi; +Cc: gdb-patches
On Jan 24 2018, Yao Qi <qiyaoltc@gmail.com> wrote:
> 2018-01-24 Yao Qi <yao.qi@linaro.org>
>
> * gdb.base/attach.exp (do_attach_tests): Set sysroot to ".*".
.* can match newlines, better avoid that.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix gdb.base/attach.exp fails when gdb is configured --with-sysroot=/
2018-01-24 16:03 ` Andreas Schwab
@ 2018-01-24 16:12 ` Yao Qi
2018-02-01 14:51 ` Yao Qi
0 siblings, 1 reply; 4+ messages in thread
From: Yao Qi @ 2018-01-24 16:12 UTC (permalink / raw)
To: Andreas Schwab; +Cc: GDB Patches
On Wed, Jan 24, 2018 at 4:03 PM, Andreas Schwab <schwab@suse.de> wrote:
> On Jan 24 2018, Yao Qi <qiyaoltc@gmail.com> wrote:
>
>> 2018-01-24 Yao Qi <yao.qi@linaro.org>
>>
>> * gdb.base/attach.exp (do_attach_tests): Set sysroot to ".*".
>
> .* can match newlines, better avoid that.
>
OK, updated it to "\[^\r\n\]*".
--
Yao (齐尧)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix gdb.base/attach.exp fails when gdb is configured --with-sysroot=/
2018-01-24 16:12 ` Yao Qi
@ 2018-02-01 14:51 ` Yao Qi
0 siblings, 0 replies; 4+ messages in thread
From: Yao Qi @ 2018-02-01 14:51 UTC (permalink / raw)
To: Andreas Schwab; +Cc: GDB Patches
On Wed, Jan 24, 2018 at 4:12 PM, Yao Qi <qiyaoltc@gmail.com> wrote:
> On Wed, Jan 24, 2018 at 4:03 PM, Andreas Schwab <schwab@suse.de> wrote:
>> On Jan 24 2018, Yao Qi <qiyaoltc@gmail.com> wrote:
>>
>>> 2018-01-24 Yao Qi <yao.qi@linaro.org>
>>>
>>> * gdb.base/attach.exp (do_attach_tests): Set sysroot to ".*".
>>
>> .* can match newlines, better avoid that.
>>
>
> OK, updated it to "\[^\r\n\]*".
>
I pushed it in.
--
Yao (齐尧)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-02-01 14:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-24 15:52 [PATCH] Fix gdb.base/attach.exp fails when gdb is configured --with-sysroot=/ Yao Qi
2018-01-24 16:03 ` Andreas Schwab
2018-01-24 16:12 ` Yao Qi
2018-02-01 14:51 ` Yao Qi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).