From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44780 invoked by alias); 21 Nov 2016 18:23:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 44761 invoked by uid 89); 21 Nov 2016 18:23:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-qt0-f179.google.com Received: from mail-qt0-f179.google.com (HELO mail-qt0-f179.google.com) (209.85.216.179) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 21 Nov 2016 18:23:49 +0000 Received: by mail-qt0-f179.google.com with SMTP id p16so208282254qta.0 for ; Mon, 21 Nov 2016 10:23:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=JD6ENE4S6ZJn5LE6jKp+Z8rYIf1SDAja0d5tP6/4md4=; b=dy+gemPTZp4L8SSIyw0ATAm+YNYoMEk4gUmV25/6oSu0HV0BBO0078a1KQCgVf5zey BkrS7X5XgbguwXHYoXscHCwG/RKy00iyQXsIjxCC93aaK/0MEIo7ahdcAqwKiq6JJu6f 4Y7oU+bOnYcxhLteJRgF0sBlUSuqlePJ/33ocVSTaCMBLncF+sB7vknJNn4U+U4kUR9q 4hFeqWDLM44TLWZDQ3hnoLIzR6AgMsNxCTq3mabk6yxvDxO2kGd/BlAtvpXEd9QEx9a8 FFQqM91jXjx5SBURdd6tZ7ZvJ+N3+yTiMDiBDv+4KwgjpwnaNzW4MU/PmCyddsalC2K7 JPMg== X-Gm-Message-State: AKaTC02USaOaReEqAdY4i406C5DAnBMe21V0t0vDE93k/zRPgu+rZ6hd+GvaJ7OlJ5vulltRy8YsWASUMdetVw== X-Received: by 10.200.52.221 with SMTP id x29mr10127321qtb.19.1479752627430; Mon, 21 Nov 2016 10:23:47 -0800 (PST) MIME-Version: 1.0 Received: by 10.12.149.55 with HTTP; Mon, 21 Nov 2016 10:23:47 -0800 (PST) In-Reply-To: <20161121141428.GB28605@E107787-LIN> References: <20161114125143.GA22037@E107787-LIN> <20161114163832.3C14F10B924@oc8523832656.ibm.com> <20161121141428.GB28605@E107787-LIN> From: Yao Qi Date: Mon, 21 Nov 2016 18:23:00 -0000 Message-ID: Subject: Re: set_value_component_location in apply_val_pretty_printer To: Ulrich Weigand Cc: user-agent@de.ibm.com, "gdb-patches@sourceware.org" , Tom Tromey Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00614.txt.bz2 On Mon, Nov 21, 2016 at 2:14 PM, Yao Qi wrote: > > - if (VALUE_LVAL (array) =3D=3D lval_memory && value_lazy (array)) > - v =3D allocate_value_lazy (elt_type); > - else > - { > - v =3D allocate_value (elt_type); > - value_contents_copy (v, value_embedded_offset (v), > - array, value_embedded_offset (array) + elt_off= s, > - elt_size); > - } > - > - set_value_component_location (v, array); > - VALUE_REGNUM (v) =3D VALUE_REGNUM (array); > - VALUE_NEXT_FRAME_ID (v) =3D VALUE_NEXT_FRAME_ID (array); > - set_value_offset (v, value_offset (array) + elt_offs); > - return v; > + return value_from_component (array, elt_type, elt_offs); > } > > I removed the code setting VALUE_NEXT_FRAME_ID, but value_from_component only sets VALUE_FRAME_ID. The change above is not equivalent, and it causes some regressions in https://sourceware.org/ml/gdb-testers/2016-q4/msg03381.html Sorry about that. The fix would be setting both VALUE_NEXT_FRAME_ID and VALUE_FRAME_ID in value_from_component. I'll give a fix. --=20 Yao (=E9=BD=90=E5=B0=A7)