From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 84244 invoked by alias); 13 Feb 2018 16:48:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 84112 invoked by uid 89); 13 Feb 2018 16:48:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-qk0-f182.google.com Received: from mail-qk0-f182.google.com (HELO mail-qk0-f182.google.com) (209.85.220.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 13 Feb 2018 16:48:25 +0000 Received: by mail-qk0-f182.google.com with SMTP id i184so12117967qkf.10 for ; Tue, 13 Feb 2018 08:48:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Jr/ydQnvQloDICO4PsyDpdr6f3wG+GP1ruz4bPNsfqk=; b=JyMxywTPAUumoo/NQRLtv+ROoSi6/X0rv3wCZixQ7N9aQDQDdmYz3d1nft6KdNJHGJ XVEozRX/zbWSWbuVfc+/tEvwbskd2Lo01wknZcQnckJP0vRgUhpw2XZ4hNtzKbB2E6R8 61uqNG2mnZKNER0cD5Yg0q+QTxfzBzsDpaao78ANCEJgJL8QPWsJsde18Z+u49c4xwYt vyc9PEq0SbdDXKdgYERTQCWi4Yy9PQLLzDo/p2vq9HtWk2AP+lUaH38QOb49oDiGrftr h7yctUgWW1uHJcElzM0DP/cDmb/lLWi8rc6+RLjtxRENwLG6Xike+2r/ua7N5Y+kYzgZ mBwQ== X-Gm-Message-State: APf1xPDjN3xUexJMQFzZR/TSIiLeZeB8dhaQqjW/rFEhN+EJO8x65a1U XvssaRAs2rD/W3LOjAe/qxZJccN9EiU8QQgzEDeodQ== X-Google-Smtp-Source: AH8x225eges81j+MM1QX7NVve2vuMY6rXoKbbKcbg61dMVpbCLQxFHQWmQfr+CCNdRSBDZnk97I7QKXgqfYfjnYZIv8= X-Received: by 10.55.220.197 with SMTP id v188mr2826156qki.147.1518540500050; Tue, 13 Feb 2018 08:48:20 -0800 (PST) MIME-Version: 1.0 Received: by 10.12.153.232 with HTTP; Tue, 13 Feb 2018 08:48:19 -0800 (PST) In-Reply-To: <1516976072-19282-2-git-send-email-markus.t.metzger@intel.com> References: <1516976072-19282-1-git-send-email-markus.t.metzger@intel.com> <1516976072-19282-2-git-send-email-markus.t.metzger@intel.com> From: Yao Qi Date: Tue, 13 Feb 2018 16:48:00 -0000 Message-ID: Subject: Re: [PATCH v2 1/7] common: add scoped_fd To: Markus Metzger Cc: GDB Patches Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg00186.txt.bz2 On Fri, Jan 26, 2018 at 2:14 PM, Markus Metzger wrote: > + > +/* Test that the file descriptor is closed. */ > +static void > +test_destroy () > +{ > + char filename[] =3D "scoped_fd-selftest-XXXXXX"; > + int fd =3D mkstemp (filename); > + SELF_CHECK (fd >=3D 0); Hi Markus, I failed to build this file with i686-w64-mingw32-g++ 4.8.2, shipped in Ubuntu 14.04. gdb/unittests/scoped_fd-selftests.c:37:29: error: =E2=80=98mkstemp=E2=80=99= was not declared in this scope int fd =3D mkstemp (filename); ^ gdb/unittests/scoped_fd-selftests.c: In function =E2=80=98void selftests::scoped_fd::test_release()=E2=80=99: gdb/unittests/scoped_fd-selftests.c:56:29: error: =E2=80=98mkstemp=E2=80=99= was not declared in this scope int fd =3D mkstemp (filename); ^ There is no such error with i686-w64-mingw32-g++ 5.3.1. Can we use "open" instead? --=20 Yao (=E9=BD=90=E5=B0=A7)