From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5218 invoked by alias); 28 Jun 2016 14:50:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5202 invoked by uid 89); 28 Jun 2016 14:50:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=value_type, Hx-spam-relays-external:209.85.218.67, H*RU:209.85.218.67 X-HELO: mail-oi0-f67.google.com Received: from mail-oi0-f67.google.com (HELO mail-oi0-f67.google.com) (209.85.218.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 28 Jun 2016 14:49:55 +0000 Received: by mail-oi0-f67.google.com with SMTP id d132so3125109oig.2 for ; Tue, 28 Jun 2016 07:49:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ivQg3NfjpsaWcnPIrTdp5/8jEcyfQg1Cbuq7oq7Cofg=; b=GvG5xWxvohjS6gQmlQIjclQg4IO9onFsDFBNfW9EkLbfb4bfyehcH2bxODwsMSlK/S fqVYMr4e5slNJrmA7pgHIuWCIXxAiXyhXa+VFLgKf0pCpcJjnb88RkYgTOcaOERK3m7Z mpjOUwyrdWkCplMsMuqnmGwZVKPVJKeuWh9gwawy//5buU3tOGjsu13yOLDbGUhZzgye zZGIpeiunws9vLaW1sutcGWAXOdxBf2HvcIg+X+hYzcj0XatPBhe2BvZ4iwwl1AI9x9J jVNTt4xK72/z9Yq7hx+jOELC3E2aWKAtsKmtPWKZyN5KUx7nd6JOr7EIHOhhkNxJvA9v fi7A== X-Gm-Message-State: ALyK8tL3GcdIN4LrfMbqURn0MwxFr/KXvBVi88TE07gkXLnVtVMoNjIDibNID2NNl8aNOMnOMMhPXuQwCRd1Rw== X-Received: by 10.157.11.230 with SMTP id 93mr2115386oth.103.1467125393523; Tue, 28 Jun 2016 07:49:53 -0700 (PDT) MIME-Version: 1.0 Received: by 10.202.182.130 with HTTP; Tue, 28 Jun 2016 07:49:53 -0700 (PDT) In-Reply-To: <1465248812-23902-6-git-send-email-tom@tromey.com> References: <1465248812-23902-1-git-send-email-tom@tromey.com> <1465248812-23902-6-git-send-email-tom@tromey.com> From: Yao Qi Date: Tue, 28 Jun 2016 14:50:00 -0000 Message-ID: Subject: Re: [RFA 5/6] Remove unused variables To: Tom Tromey Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-06/txt/msg00466.txt.bz2 On Mon, Jun 6, 2016 at 10:33 PM, Tom Tromey wrote: > diff --git a/gdb/python/py-framefilter.c b/gdb/python/py-framefilter.c > index aa25911..b663f50 100644 > --- a/gdb/python/py-framefilter.c > +++ b/gdb/python/py-framefilter.c > @@ -211,13 +211,11 @@ py_print_type (struct ui_out *out, struct value *va= l) > > TRY > { > - struct type *type; > struct ui_file *stb; > struct cleanup *cleanup; > > stb =3D mem_fileopen (); > cleanup =3D make_cleanup_ui_file_delete (stb); > - type =3D check_typedef (value_type (val)); > type_print (value_type (val), "", stb, -1); > ui_out_field_stream (out, "type", stb); > do_cleanups (cleanup); check_typedef has side effects, IIUC, so we can't remove the call to it. --=20 Yao (=E9=BD=90=E5=B0=A7)