From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25925 invoked by alias); 5 Jan 2018 08:56:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25914 invoked by uid 89); 5 Jan 2018 08:56:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:2068, officer, dear, kindly X-HELO: mail-qt0-f194.google.com Received: from mail-qt0-f194.google.com (HELO mail-qt0-f194.google.com) (209.85.216.194) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 05 Jan 2018 08:56:38 +0000 Received: by mail-qt0-f194.google.com with SMTP id r39so4943737qtr.13 for ; Fri, 05 Jan 2018 00:56:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=LrEicO3lapCRMRZ3ToHx3T8THMpAG7EWGkRgzn12cjE=; b=Wc6Yp8KtxZ3pysolR8xt1fdeNxTU3sXzC+YhozRf3A701NGcOFMNfYDvm96R2rCkOR YjfTURI+ymChtPTQaE1oqOpZJvgIgwZae+OzoLuGQiUNttKciWc7SFrF33mEmKcHQfn8 Xa+OCMs+RcJzDuwpO7OVqzp33kRAngiL6YxR2TtggT46x9B0XxZJ5caRMO6qM4lAxrGv mC+wA8QHGHMbFn98+YkxJ3h9EEkcHdBo1aqF0942T0hJcHqkZhjaDqkowtlYGsX4DiUK KJhRoGH8Jx9HYPpJFEXUwLU71e2SOF1jS3dsz7tgxpKEhIBCbvFGu1IMHVwTslySUkhn k6Cw== X-Gm-Message-State: AKwxytdricm3IL8sAg78s7HXG/aLMg4yhmuCuXKqPCWkZ8zR1RQE6HBZ a9giqH3Yqat/eu4H4xu5fxT9nR0n4Znh8VpW9gpRaQ== X-Google-Smtp-Source: ACJfBostL9/Ty4ANJkWPLLfwlfGUKPPI8w7NbRZ6gVx+pL89qf6xedJLENXoPte3voFFLqKJ8IMvhjCv4j6+2oOV6zk= X-Received: by 10.200.23.175 with SMTP id o44mr3437589qtj.255.1515142596430; Fri, 05 Jan 2018 00:56:36 -0800 (PST) MIME-Version: 1.0 Received: by 10.12.132.161 with HTTP; Fri, 5 Jan 2018 00:56:35 -0800 (PST) In-Reply-To: <20180105072540.gxbdc5nhwzevlawl@adacore.com> References: <7a9dac5b3cc3b50f9733deef0a606c28b099ed1f-gdb-8.1-branch-breakage@gdb-build> <20180105072540.gxbdc5nhwzevlawl@adacore.com> From: Yao Qi Date: Fri, 05 Jan 2018 08:56:00 -0000 Message-ID: Subject: Re: Oh dear. I regret to inform you that commit 7a9dac5b3cc3b50f9733deef0a606c28b099ed1f might be unfortunate [gdb-8.1-branch] To: Joel Brobecker Cc: gdb-buildbot@sergiodj.net, GDB Patches Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2018-01/txt/msg00094.txt.bz2 On Fri, Jan 5, 2018 at 7:25 AM, Joel Brobecker wrot= e: >> It is a matter of great regret and sadness to inform you that commit: >> >> Set development mode to "off" by default. >> 7a9dac5b3cc3b50f9733deef0a606c28b099ed1f >> >> might have made GDB unwell. Since I am just your Butler BuildBot, >> I kindly ask that a human superior officer double-check this. >> >> Please note that if you are reading this message on gdb-patches, there m= ight >> be other builders broken. > > The patch controls the configure variab1e "development". Looking > at the configure.ac script, I found that the selftest tests > are only activated when it is set: > > if $development; then > AC_DEFINE(GDB_SELF_TEST, 1, > [Define if self-testing features should be enabled]) > CONFIG_OBS=3D"$CONFIG_OBS \$(SUBDIR_UNITTESTS_OBS)" > CONFIG_SRCS=3D"$CONFIG_SRCS \$(SUBDIR_UNITTESTS_SRCS)" > fi > > I assume the error is related to the above, since it's a link > failure related to selftests... > This is about including self test cases when $development is true. It is n= ot related to the link failure below... > | [...] > | ../readline/libreadline.a ../opcodes/libopcodes.a ../bfd/l= ibbfd.a -L./../zlib -lz ../libiberty/libiberty.a ../libdecnumber/libdecnum= ber.a -ldl -ldl -lncursesw -lm -ldl -lguile-2.0 -lgc -lpthread -ldl -l= util -lm -lpython2.7 -lexpat -llzma -lbabeltrace -lbabeltrace-ctf -lipt ../= libiberty/libiberty.a build-gnulib/import/libgnu.a -ldl -Wl,--dynamic-li= st=3D../../binutils-gdb/gdb/proc-service.list > | selftest.o: In function `selftests::run_tests(char const*)': > | /home/gdb-buildbot-2/fedora-x86-64-4/fedora-x86-64/build/gdb/../../= binutils-gdb/gdb/common/selftest.c:97: undefined reference to `selftests::r= eset()' > | collect2: error: ld returned 1 exit status selftest.o shouldn't be compiled when $development is false. I think selft= est.o shouldn't be put into COMMON_OBS unconditionally. I'll take a look. --=20 Yao (=E9=BD=90=E5=B0=A7)