From: Yao Qi <qiyaoltc@gmail.com>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] gdb.btrace/*.exp: Make test names unique
Date: Thu, 06 Oct 2016 08:44:00 -0000 [thread overview]
Message-ID: <CAH=s-PNeTXVXG0NiT49r+S9hwk_rqOV-Zw8VLrdHhwPtz8SGaQ@mail.gmail.com> (raw)
In-Reply-To: <20161003191729.1412-1-simon.marchi@ericsson.com>
On Mon, Oct 3, 2016 at 8:17 PM, Simon Marchi
Patch is good to me, some nits below,
> # we can read memory if we explicitly allow it.
> -gdb_test_no_output "set record btrace replay-memory-access read-write"
> -gdb_test "print glob" "1"
> +with_test_prefix "replaying, replay-memory-access = read-write" {
> + gdb_test_no_output "set record btrace replay-memory-access read-write"
Nit, I'd like to move this test out of with_test_prefix block, as it is unique.
> + gdb_test "print glob" "1"
> +}
>
> # we can't if we don't explicitly allow it.
> -gdb_test_no_output "set record btrace replay-memory-access read-only"
> -gdb_test "print glob" "unavailable\[^\\\r\\\n\]*"
> +with_test_prefix "replaying, replay-memory-access = read-only" {
> + gdb_test_no_output "set record btrace replay-memory-access read-only"
Likewise.
> + gdb_test "print glob" "unavailable\[^\\\r\\\n\]*"
> +}
>
> diff --git a/gdb/testsuite/gdb.btrace/delta.exp b/gdb/testsuite/gdb.btrace/delta.exp
> index c9dbf38..c822400 100644
> --- a/gdb/testsuite/gdb.btrace/delta.exp
> +++ b/gdb/testsuite/gdb.btrace/delta.exp
> @@ -47,7 +47,7 @@ with_test_prefix "no trace" {
> }
>
> # we record each single-step, even if we have not seen a branch, yet.
> -gdb_test "stepi"
> +gdb_test "stepi" "main\.4.*" "stepi #1"
>
> proc check_trace {} {
> gdb_test "info record" [multi_line \
> @@ -70,18 +70,18 @@ with_test_prefix "twice" {
> }
>
> # check that we can reverse-stepi that instruction
> -gdb_test "reverse-stepi"
> +gdb_test "reverse-stepi" "main\.3.*"
This doesn't change the test message in gdb.sum, but good
to have it.
--
Yao (齐尧)
next prev parent reply other threads:[~2016-10-06 8:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-03 19:17 Simon Marchi
2016-10-06 8:44 ` Yao Qi [this message]
2016-10-06 13:58 ` Metzger, Markus T
2016-10-06 14:32 ` Simon Marchi
2016-10-07 7:43 ` Metzger, Markus T
2016-10-07 13:04 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH=s-PNeTXVXG0NiT49r+S9hwk_rqOV-Zw8VLrdHhwPtz8SGaQ@mail.gmail.com' \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).