From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 41364 invoked by alias); 19 Jul 2016 10:06:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 41352 invoked by uid 89); 19 Jul 2016 10:06:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:2000 X-HELO: mail-oi0-f46.google.com Received: from mail-oi0-f46.google.com (HELO mail-oi0-f46.google.com) (209.85.218.46) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 19 Jul 2016 10:06:12 +0000 Received: by mail-oi0-f46.google.com with SMTP id l72so18488090oig.2 for ; Tue, 19 Jul 2016 03:06:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=P6hO8MOy7BO/LIIfIfnYX3ZWToPRw3QTMOmRBjnc3/A=; b=NBwOs4HyIFa57PfjTDUX2hCYUBw4DOsneDrATF7aoChZdemtgSeXFMya5/15Swyze8 iQ+JBD7opJdHkw/zp4HHVUkDJTqIAvnDCr1n6JU6gB02ZrNeCssqq+4LTxygdHptSUje IFawOY8h27VkRAqNVyQ2AiqqBGEEorZLVNZmspcdvq1vx33I4QDkzyRtLj/XYORWi5+h 5ti3a/PnktRMhXd+h8vdbgc6wWJaCe4ATWZ2uIc/wPfC3XAPrGrJocMRUewuxF6HGBIm QIaNXtyH6C4MUHuJmwPxzHR/UG1jQ8Qi58vvqGrf1GohqFXxgGT/Hm42DdZwtQesTLhO YIrQ== X-Gm-Message-State: ALyK8tJc0XoVwWESZ8luKibCNXpN2ii50oVsmGWElLm4X8e88ipUnhsVhUFIZZUYmNCSANjYkSD1E+XYgm07Fg== X-Received: by 10.157.15.236 with SMTP id m41mr23654194otd.3.1468922770308; Tue, 19 Jul 2016 03:06:10 -0700 (PDT) MIME-Version: 1.0 Received: by 10.202.105.138 with HTTP; Tue, 19 Jul 2016 03:06:09 -0700 (PDT) In-Reply-To: <20160718113348.GA25789@host1.jankratochvil.net> References: <20160717143003.GA12147@host1.jankratochvil.net> <20160718113348.GA25789@host1.jankratochvil.net> From: Yao Qi Date: Tue, 19 Jul 2016 10:06:00 -0000 Message-ID: Subject: Re: [testsuite patch] Skip py-unwind.exp on x86_64 -m32 To: Jan Kratochvil Cc: "gdb-patches@sourceware.org" , Sergio Durigan Junior Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-07/txt/msg00200.txt.bz2 On Mon, Jul 18, 2016 at 12:33 PM, Jan Kratochvil wrote: > On Mon, 18 Jul 2016 12:04:27 +0200, Yao Qi wrote: >> This problem is slightly different from "how to run testsuite in cross-a= rch >> mode", IMO. >> py-unwind.py defines a unwinder, in an arch-specific way. It has nothing >> wrong. >> However, py-unwind.py should be more portable, which means, it should >> define unwdiner for each arch it supports, and py-unwind.exp or py-unwin= d.py >> chooses the right python unwinder according to the arch. IOW, we need to >> define a python unwinder for i386, and use it when arch is i386. > > There will always exist at least one unsupported arch for an arch-specific > testcase. I do not think it makes sense to say that very every testcase = in > the testsuite must support very every arch supported by GDB. > > So we can say that py-unwind.exp just does not support arch i386. > I do not find that wrong. It is still better to get one test case cover one more arch. > > Wrong is that it should not FAIL on unsupported arch, it should skip the > testcase on unsupported arch. > IMO, it is wrong that py-unwind.py creates an x86_64 specific unwinder. py-unwind.py should create a unwinder instance according to the arch if the arch is supported. On i386, or other archs, like arm, mips, py-unwind.py can error, and py-unwind.exp knows unwinder is not created successfully, and mark the test unsupported. If people want to extend py-unwind.py for their archs, they can modify py-unwind.py to create an unwinder instance for their own arch. > The problem here is that py-unwind.exp thinks that it runs on arch x86_64= but > it runs on arch i386. > > Even if py-unwind.exp did support i386 it would still FAIL because it wou= ld > run the testcase for %rbp/%rsp/%rip. py-unwind.exp does nothing on arch specific thing, so py-unwind.exp shouldn= 't be aware of the arch difference, but py-unwind.py should. --=20 Yao (=E9=BD=90=E5=B0=A7)