public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Yao Qi <qiyaoltc@gmail.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 0/7] Class-fy partial_die_info
Date: Thu, 25 Jan 2018 14:03:00 -0000	[thread overview]
Message-ID: <CAH=s-PNt4yBz8XmSuSSVUEwzp+6dfteZ5gMB2nBg6OaFmwq76A@mail.gmail.com> (raw)
In-Reply-To: <20180125120524.4q5zyi5jbpotof6n@adacore.com>

On Thu, Jan 25, 2018 at 12:05 PM, Joel Brobecker <brobecker@adacore.com> wrote:
>
> What's the advantage of turning this struct into a class?
> Is it memory management?
>
> (sorry if it's obvious from the code - C++ dummy, here)
>

I am fixing PR 22531, that is GDB should coalesce consecutive line
table entries in some cases.  However, one exception here is that
GCC emits two entries to mark the end of prologue.  In this case, GDB
can't coalesce them.

I wrote some unit tests to dwarf_decode_lines_1,
with an input to provide dwarf line table, and verify dwarf_decode_lines_1
can get line table correctly.  In order to write unit tests, I want to easily
create the context for each unit test, like dwarf2_per_cu_data, dwarf2_cu,
line_header, etc.  So I have to class-fy them, and class-fy these structs
requires class-fy other structs, it turns out that I nearly class-fy all structs
in dwarf2read.c.  This patch series is just part of the whole work.

-- 
Yao (齐尧)

      reply	other threads:[~2018-01-25 14:03 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-25  9:38 Yao Qi
2018-01-25  9:38 ` [PATCH 3/7] Change find_partial_die_in_comp_unit to dwarf2_cu::find_partial_die Yao Qi
2018-01-25  9:38 ` [PATCH 4/7] Class-fy partial_die_info Yao Qi
2018-01-25 16:19   ` Tom Tromey
2018-01-26 17:25     ` Yao Qi
2018-01-26 20:55       ` Tom Tromey
2018-01-29  1:15   ` Simon Marchi
2018-01-30 10:49     ` Yao Qi
2018-01-30 15:11       ` Pedro Alves
2018-01-30 11:39     ` Pedro Alves
2018-01-31  3:46       ` Simon Marchi
2018-01-31 11:55         ` Yao Qi
2018-01-31 15:33         ` Pedro Alves
2018-01-25  9:38 ` [PATCH 2/7] Don't check abbrev is NULL in read_partial_die Yao Qi
2018-01-25  9:38 ` [PATCH 7/7] Move read_partial_die to partial_die_info::read Yao Qi
2018-01-29  1:58   ` Simon Marchi
2018-01-25  9:38 ` [PATCH 5/7] Remove one argument abbrev_len in read_partial_die Yao Qi
2018-01-29  1:30   ` Simon Marchi
2018-01-25  9:38 ` [PATCH 6/7] Move fixup_partial_die to partial_die_info::fixup Yao Qi
2018-01-25 12:59   ` Pedro Alves
2018-01-25 14:45     ` Yao Qi
2018-01-25  9:38 ` [PATCH 1/7] Re-write partial_die_info allocation in load_partial_dies Yao Qi
2018-01-25 12:05 ` [PATCH 0/7] Class-fy partial_die_info Joel Brobecker
2018-01-25 14:03   ` Yao Qi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH=s-PNt4yBz8XmSuSSVUEwzp+6dfteZ5gMB2nBg6OaFmwq76A@mail.gmail.com' \
    --to=qiyaoltc@gmail.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).