public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* New ARI warning Fri Jul 15 01:56:06 UTC 2016
@ 2016-07-15  1:56 GDB Administrator
  2016-07-15  4:22 ` Tom Tromey
  0 siblings, 1 reply; 4+ messages in thread
From: GDB Administrator @ 2016-07-15  1:56 UTC (permalink / raw)
  To: gdb-patches

259a260
> gdb/inflow.c:401: regression: ATTRIBUTE_UNUSED: Do not use ATTRIBUTE_UNUSED, do not bother (GDB is compiled with -Werror and, consequently, is not able to tolerate false warnings.  Since -Wunused-param produces such warnings, neither that warning flag nor ATTRIBUTE_UNUSED are used by GDB
gdb/inflow.c:401:      int result ATTRIBUTE_UNUSED;

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: New ARI warning Fri Jul 15 01:56:06 UTC 2016
  2016-07-15  1:56 New ARI warning Fri Jul 15 01:56:06 UTC 2016 GDB Administrator
@ 2016-07-15  4:22 ` Tom Tromey
  2016-07-15 11:57   ` Yao Qi
  2016-07-15 15:44   ` Joel Brobecker
  0 siblings, 2 replies; 4+ messages in thread
From: Tom Tromey @ 2016-07-15  4:22 UTC (permalink / raw)
  To: GDB Administrator; +Cc: gdb-patches

>>>>> ">" == GDB Administrator <gdbadmin@sourceware.org> writes:

>> gdb/inflow.c:401: regression: ATTRIBUTE_UNUSED: Do not use
>> ATTRIBUTE_UNUSED, do not bother (GDB is compiled with -Werror and,
>> consequently, is not able to tolerate false warnings.  Since
>> -Wunused-param produces such warnings, neither that warning flag nor
>> ATTRIBUTE_UNUSED are used by GDB

I think it's time for this warning to go -- I don't recall the situation
back when, but now there are multiple flags that might produce this
warning, and I'd like gdb to enable at least two of them.

I don't remember how to update ARI.  Is it enough to edit
contrib/ari/gdb_ari.sh?

Tom

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: New ARI warning Fri Jul 15 01:56:06 UTC 2016
  2016-07-15  4:22 ` Tom Tromey
@ 2016-07-15 11:57   ` Yao Qi
  2016-07-15 15:44   ` Joel Brobecker
  1 sibling, 0 replies; 4+ messages in thread
From: Yao Qi @ 2016-07-15 11:57 UTC (permalink / raw)
  To: Tom Tromey; +Cc: GDB Administrator, gdb-patches, muller

On Fri, Jul 15, 2016 at 5:22 AM, Tom Tromey <tom@tromey.com> wrote:
>
> I don't remember how to update ARI.  Is it enough to edit
> contrib/ari/gdb_ari.sh?

Yes, I think so.  Pierre, correct me if I am wrong.

-- 
Yao (齐尧)

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: New ARI warning Fri Jul 15 01:56:06 UTC 2016
  2016-07-15  4:22 ` Tom Tromey
  2016-07-15 11:57   ` Yao Qi
@ 2016-07-15 15:44   ` Joel Brobecker
  1 sibling, 0 replies; 4+ messages in thread
From: Joel Brobecker @ 2016-07-15 15:44 UTC (permalink / raw)
  To: Tom Tromey; +Cc: GDB Administrator, gdb-patches

> >> gdb/inflow.c:401: regression: ATTRIBUTE_UNUSED: Do not use
> >> ATTRIBUTE_UNUSED, do not bother (GDB is compiled with -Werror and,
> >> consequently, is not able to tolerate false warnings.  Since
> >> -Wunused-param produces such warnings, neither that warning flag nor
> >> ATTRIBUTE_UNUSED are used by GDB
> 
> I think it's time for this warning to go -- I don't recall the situation
> back when, but now there are multiple flags that might produce this
> warning, and I'd like gdb to enable at least two of them.
> 
> I don't remember how to update ARI.  Is it enough to edit
> contrib/ari/gdb_ari.sh?

I took a quick look, and it looks like not (yet). We have what
appears to be an older copy of that script, which we then use
to generate the ARI data. Switching over to the version from
the snapshot seems easy enough, but I'm going to be unavailable
in the next couple of days if something goes wrong.

What I would recommend, to start, is that Tom makes the modification.
I'll change our nightly scripts to use that version of the scripts,
and we'll see what happens.

We have the same issue with gdb_find.sh as well.

-- 
Joel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-07-15 15:44 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-15  1:56 New ARI warning Fri Jul 15 01:56:06 UTC 2016 GDB Administrator
2016-07-15  4:22 ` Tom Tromey
2016-07-15 11:57   ` Yao Qi
2016-07-15 15:44   ` Joel Brobecker

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).