From: Yao Qi <qiyaoltc@gmail.com>
To: Andreas Arnez <arnez@linux.vnet.ibm.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Ulrich Weigand <uweigand@de.ibm.com>
Subject: Re: [PATCH 5/6] linux-nat: Add function lwp_is_stepping
Date: Thu, 15 Sep 2016 15:08:00 -0000 [thread overview]
Message-ID: <CAH=s-PO8zW==KbGz2DniyT3ca-FRK52=+Bzbw5vtj4k0+c0uSQ@mail.gmail.com> (raw)
In-Reply-To: <1473940907-4449-4-git-send-email-arnez@linux.vnet.ibm.com>
Hi Andreas,
Patch is good to me. One nit below ...
On Thu, Sep 15, 2016 at 1:01 PM, Andreas Arnez <arnez@linux.vnet.ibm.com> wrote:
> Add the function lwp_is_stepping which indicates whether the given LWP
> is currently single-stepping. This is a common interface, usable from
> native GDB as well as from gdbserver.
"single-stepping" in hardware or software? I know it is hardware single
step.
>
> +/* Return nonzero if we are single-stepping this LWP. */
> +
> +extern int lwp_is_stepping (struct lwp_info *lwp);
> +
> #endif /* LINUX_NAT_H */
in gdbserver,
struct lwp_info
{
....
/* If this flag is set, the last continue operation at the ptrace
level on this process was a single-step. */
int stepping;
in gdb,
struct lwp_info
{
...
/* Non-zero if we were stepping this LWP. */
int step;
Looks the comments in gdbservers is better than the comments in
gdb. lwp_is_stepping, as an api, should be documented clearly.
Something like,
/* Return nonzero if we are single-stepping this LWP at the
ptrace level. */
--
Yao (齐尧)
next prev parent reply other threads:[~2016-09-15 15:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-15 11:53 [PATCH 0/6] S390: Watchpoint enhancements and hardware breakpoints Andreas Arnez
2016-09-15 11:54 ` [PATCH] Fix order of inferiors in "thread apply all" Andreas Arnez
2016-09-15 12:03 ` Andreas Arnez
2016-09-15 11:59 ` [PATCH 1/6] S390: Avoid direct access to lwp_info structure Andreas Arnez
2016-09-15 12:01 ` [PATCH 3/6] S390: Multi-inferior watchpoint support Andreas Arnez
2016-09-15 12:02 ` [PATCH 5/6] linux-nat: Add function lwp_is_stepping Andreas Arnez
2016-09-15 15:08 ` Yao Qi [this message]
2016-09-15 12:02 ` [PATCH 6/6] S390: Hardware breakpoint support Andreas Arnez
2016-09-15 12:02 ` [PATCH 2/6] S390: Migrate watch areas from list to VEC type Andreas Arnez
2016-09-15 12:02 ` [PATCH 4/6] S390: Enable "maint set show-debug-regs" Andreas Arnez
2016-09-15 14:11 ` [PATCH 0/6] S390: Watchpoint enhancements and hardware breakpoints Pedro Alves
2016-09-16 12:43 ` Ulrich Weigand
2016-09-16 15:43 ` Pedro Alves
2016-09-16 17:30 ` Andreas Arnez
2016-09-15 14:58 ` Yao Qi
2016-09-15 17:14 ` Andreas Arnez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH=s-PO8zW==KbGz2DniyT3ca-FRK52=+Bzbw5vtj4k0+c0uSQ@mail.gmail.com' \
--to=qiyaoltc@gmail.com \
--cc=arnez@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).