From: Yao Qi <qiyaoltc@gmail.com>
To: Keith Seitz <keiths@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH master/7.12] Fix heap-buffer-overflow in explicit_location_lex_one
Date: Mon, 15 Aug 2016 11:34:00 -0000 [thread overview]
Message-ID: <CAH=s-PO=-4XoQmGWyZ37s6opsgKb0iJz6W83-BtuQcUYOhtA7g@mail.gmail.com> (raw)
In-Reply-To: <57ADFBD5.5060507@redhat.com>
On Fri, Aug 12, 2016 at 5:39 PM, Keith Seitz <keiths@redhat.com> wrote:
> While your patch alters the behavior ever so slightly (originally, it
> was meant to skip over "operator," -- now it skips over "operator" and
> the next char), I don't think that it will impact what this code
> actually does. It looks good to me.
>
Thanks for the review, Keith. Patch is pushed into master and 7.12.
--
Yao (齐尧)
prev parent reply other threads:[~2016-08-15 11:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-12 12:45 Yao Qi
2016-08-12 16:39 ` Keith Seitz
2016-08-15 11:34 ` Yao Qi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH=s-PO=-4XoQmGWyZ37s6opsgKb0iJz6W83-BtuQcUYOhtA7g@mail.gmail.com' \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).