From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11622 invoked by alias); 8 Jun 2016 14:59:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11594 invoked by uid 89); 8 Jun 2016 14:59:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1886, Hx-spam-relays-external:209.85.218.66, H*RU:209.85.218.66 X-HELO: mail-oi0-f66.google.com Received: from mail-oi0-f66.google.com (HELO mail-oi0-f66.google.com) (209.85.218.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 08 Jun 2016 14:59:46 +0000 Received: by mail-oi0-f66.google.com with SMTP id x204so2082126oia.0 for ; Wed, 08 Jun 2016 07:59:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=BX9ZffLFSzqs3NaYberPvEwctrq+UDLoGV/xpU10ziQ=; b=PIsOQPUkpkOv9cQgrZW2VoHTwbdfetLpCzu4+0FnSBuJrRi0G+xLW5I4EPj68z9QvD +abaexQyQkPzok/izD10/sag4Z11qod0V1u4wbjHAK+I+OmbnewYr2EyEXgsXdFmrSKQ 0/tLiwxxCqc43AF1MNvqRkAt7JiJEO9eMdMn7ueKHznczFRllITEKbqoJP9Vtk3iiqSi C9v3m62dkHv7MisDaQ8HbSjSAhsYTVwNNS9+y9o5vmWYqBpbFqIb4q7ysckeLaWpr+mt eayy0FdT1vCOroqXB3gIm4/m6uJom9gseuPSX0yHXIIu0ANHo30lrMZ/8QxWkZVipblk /VOw== X-Gm-Message-State: ALyK8tK2I8jkyIaxr0raxVSOcBzXOJmhRyKZfAVt0lonqqoShV+Z8ayIUyDeSfvnPEVLLf2crtdcgAQU/K3Fzg== X-Received: by 10.202.205.87 with SMTP id d84mr3081014oig.131.1465397984707; Wed, 08 Jun 2016 07:59:44 -0700 (PDT) MIME-Version: 1.0 Received: by 10.202.68.4 with HTTP; Wed, 8 Jun 2016 07:59:44 -0700 (PDT) In-Reply-To: <20160608114017.GB26734@embecosm.com> References: <1465377976-21678-1-git-send-email-andrew.burgess@embecosm.com> <20160608114017.GB26734@embecosm.com> From: Yao Qi Date: Wed, 08 Jun 2016 14:59:00 -0000 Message-ID: Subject: Re: [PATCH] gdb: Use UNSUPPORTED not FAIL for unsupported target features To: Andrew Burgess Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-06/txt/msg00160.txt.bz2 On Wed, Jun 8, 2016 at 12:40 PM, Andrew Burgess > diff --git a/gdb/testsuite/gdb.base/callfuncs.exp b/gdb/testsuite/gdb.bas= e/callfuncs.exp > index fbe896c..1ec33d8 100644 > --- a/gdb/testsuite/gdb.base/callfuncs.exp > +++ b/gdb/testsuite/gdb.base/callfuncs.exp > @@ -26,8 +26,7 @@ if [support_complex_tests] { > # Some targets can't do function calls, so don't even bother with this > # test. > if [target_info exists gdb,cannot_call_functions] { > - setup_xfail "*-*-*" 2416 > - fail "This target can not call functions" > + unsupported "This target can not call functions" > continue > } > That change makes sense to me. UNSUPPORTED is better XFAIL. There are many instances, ./gdb.base/unwindonsignal.exp: setup_xfail "*-*-*" 2416 ./gdb.base/call-signal-resume.exp: setup_xfail "*-*-*" 2416 ./gdb.base/call-rt-st.exp: setup_xfail "*-*-*" 2416 ./gdb.base/call-ar-st.exp: setup_xfail "*-*-*" 2416 ./gdb.base/ptype.exp: setup_xfail "*-*-*" 2416 ./gdb.base/callexit.exp: setup_xfail "*-*-*" 2416 ./gdb.base/callfuncs.exp: setup_xfail "*-*-*" 2416 ./gdb.base/nodebug.exp: setup_xfail "*-*-*" 2416 ./gdb.base/call-strs.exp: setup_xfail "*-*-*" 2416 ./gdb.base/printcmds.exp: setup_xfail "*-*-*" 2416 ./gdb.base/printcmds.exp: setup_xfail "*-*-*" 2416 ./gdb.threads/thread-unwindonsignal.exp: setup_xfail "*-*-*" 2416 ./gdb.threads/hand-call-in-threads.exp: setup_xfail "*-*-*" 2416 ./gdb.threads/interrupted-hand-call.exp: setup_xfail "*-*-*" 2416 ./gdb.cp/templates.exp: setup_xfail "*-*-*" 2416 ./gdb.cp/gdb2495.exp: setup_xfail "*-*-*" 2416 ./gdb.cp/virtfunc.exp: setup_xfail "*-*-*" 2416 so I think we need to clean them up too. I don't think 2416 is the PR numb= er in sourceware.org bugzilla, so we don't loose any information after the cleanup. The patch can go in without another review. --=20 Yao (=E9=BD=90=E5=B0=A7)