From: Yao Qi <qiyaoltc@gmail.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [testsuite patch] Fix recent GCC FAIL: gdb.arch/i386-signal.exp
Date: Tue, 04 Oct 2016 16:08:00 -0000 [thread overview]
Message-ID: <CAH=s-POPK4vzPa9S-OMBTQ-xda6XeDrL=F1hx5FLC8=56bZ1FA@mail.gmail.com> (raw)
In-Reply-To: <20161003203500.GA2251@host1.jankratochvil.net>
On Mon, Oct 3, 2016 at 9:35 PM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:
> The two attached patch chunks each fixes the FAIL on its own.
>
> The .exp patch is an obvious typo fix I think. The regex was written to
> accept "ADDR in main" and I find it OK as checking .debug_line validity is not
> the purpose of this testfile.
>
This is reasonable to me.
> The .c patch will properly create a new corresponding source line .debug_line
> entry for the 'mov $0x0,%eax' instruction and I also do not think it is
> relevant to the purpose of this testfile.
>
Why do we need the second one?
--
Yao (齐尧)
next prev parent reply other threads:[~2016-10-04 16:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-03 20:35 Jan Kratochvil
2016-10-04 16:08 ` Yao Qi [this message]
2016-10-04 16:19 ` Jan Kratochvil
2016-10-04 16:39 ` Jan Kratochvil
2016-10-05 8:15 ` Yao Qi
2016-10-05 19:59 ` [commit] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH=s-POPK4vzPa9S-OMBTQ-xda6XeDrL=F1hx5FLC8=56bZ1FA@mail.gmail.com' \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).