* [PATCH] Call debug_exit in linux_wait_1
@ 2016-09-22 14:42 Yao Qi
2016-09-26 5:01 ` Yao Qi
0 siblings, 1 reply; 2+ messages in thread
From: Yao Qi @ 2016-09-22 14:42 UTC (permalink / raw)
To: gdb-patches
When I read the GDBserver debug message, I find the "entering" of
linux_wait_1 doesn't match the "existing" of linux_wait_1. Looks
we don't call debug_exit somewhere in linux_wait_1 on return.
gdb/gdbserver:
2016-09-22 Yao Qi <yao.qi@linaro.org>
* linux-low.c (linux_wait_1): Call debug_exit.
---
gdb/gdbserver/linux-low.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c
index 785f0c2..dd71b59 100644
--- a/gdb/gdbserver/linux-low.c
+++ b/gdb/gdbserver/linux-low.c
@@ -3452,6 +3452,8 @@ linux_wait_1 (ptid_t ptid,
linux_resume_one_lwp (event_child, 0, 0, NULL);
+ if (debug_threads)
+ debug_exit ();
return ignore_event (ourstatus);
}
}
@@ -3547,6 +3549,9 @@ linux_wait_1 (ptid_t ptid,
linux_resume_one_lwp (event_child, event_child->stepping,
0, NULL);
+
+ if (debug_threads)
+ debug_exit ();
return ignore_event (ourstatus);
}
@@ -3602,6 +3607,10 @@ linux_wait_1 (ptid_t ptid,
linux_resume_one_lwp (event_child, event_child->stepping,
WSTOPSIG (w), info_p);
}
+
+ if (debug_threads)
+ debug_exit ();
+
return ignore_event (ourstatus);
}
@@ -3696,6 +3705,10 @@ linux_wait_1 (ptid_t ptid,
if (debug_threads)
debug_printf ("proceeding all threads.\n");
proceed_all_lwps ();
+
+ if (debug_threads)
+ debug_exit ();
+
return ignore_event (ourstatus);
}
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Call debug_exit in linux_wait_1
2016-09-22 14:42 [PATCH] Call debug_exit in linux_wait_1 Yao Qi
@ 2016-09-26 5:01 ` Yao Qi
0 siblings, 0 replies; 2+ messages in thread
From: Yao Qi @ 2016-09-26 5:01 UTC (permalink / raw)
To: gdb-patches
On Thu, Sep 22, 2016 at 3:32 PM, Yao Qi <qiyaoltc@gmail.com> wrote:
> When I read the GDBserver debug message, I find the "entering" of
> linux_wait_1 doesn't match the "existing" of linux_wait_1. Looks
> we don't call debug_exit somewhere in linux_wait_1 on return.
>
> gdb/gdbserver:
>
> 2016-09-22 Yao Qi <yao.qi@linaro.org>
>
> * linux-low.c (linux_wait_1): Call debug_exit.
Patch is pushed in.
--
Yao (齐尧)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-26 3:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-22 14:42 [PATCH] Call debug_exit in linux_wait_1 Yao Qi
2016-09-26 5:01 ` Yao Qi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).