From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 35905 invoked by alias); 1 Feb 2018 21:32:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 35894 invoked by uid 89); 1 Feb 2018 21:32:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-qt0-f175.google.com Received: from mail-qt0-f175.google.com (HELO mail-qt0-f175.google.com) (209.85.216.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 01 Feb 2018 21:32:15 +0000 Received: by mail-qt0-f175.google.com with SMTP id d54so28386112qtd.4 for ; Thu, 01 Feb 2018 13:32:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=iwqVNPbr2VEyeUqAOUUlLSzDrJNXYvcaiEXUvC8U1l4=; b=BylPVlsLueMmFNHreq44K/ojzUREmiHY5sEA2Kb7rcgJWa1Mmh3vBtTTOYmuLTeyol FLNiRwgYtUw7ESNCD6n8JRc4TWBVJUXGXeMuR1t4JhitYGoZtGrHt1tqIf2wG5fogSGd OhdrsYcTQdIybFLEKscTJhbZfkEFoaelt12w4xyy1ZZErIheSZP/DL05K5eiV0I+1Icj c0NGtPsRNkHPUMEvXJY59M+Dbtgpm7sR749DlKjgPxZHugrW+blcnN33w+zstWMKpg1S McPlYJB7qND9m9YFuIoSKtdDLZJYYUL3KBrDqRFeZppU1Yp0Ai3urfTaPk8djviadSoM KyfA== X-Gm-Message-State: APf1xPAOJTjU7oH4+melC6TCNI2/eq/FH0dyGLKSaTksDqmSjsgG6x91 CEMx1UovkDuC3HSYnH/8NIPs1nyCp5kZtBWrggE= X-Google-Smtp-Source: AH8x2257Ng4oVA/5itiC6TWH7nzJ+e7ApvdU5FLj8QBvLNvVyJJZRQJHBqUnHncnABlsuQTrjxxU0PIil2rTOJIoInk= X-Received: by 10.200.23.177 with SMTP id o46mr646614qtj.255.1517520734216; Thu, 01 Feb 2018 13:32:14 -0800 (PST) MIME-Version: 1.0 Received: by 10.12.153.232 with HTTP; Thu, 1 Feb 2018 13:32:13 -0800 (PST) In-Reply-To: <83mv0sehrq.fsf@gnu.org> References: <83h8rlyakm.fsf@gnu.org> <83lggvupt6.fsf@gnu.org> <83lgglnadl.fsf@gnu.org> <83fu6sln4o.fsf@gnu.org> <3d75778f-5c91-5680-b9fa-c2f2c902ff67@ericsson.com> <838tcklaev.fsf@gnu.org> <83607njlsh.fsf@gnu.org> <86wozwbv68.fsf@gmail.com> <83shakeku7.fsf@gnu.org> <83mv0sehrq.fsf@gnu.org> From: Yao Qi Date: Thu, 01 Feb 2018 21:32:00 -0000 Message-ID: Subject: Re: [ANNOUNCEMENT] GDB 8.1 release branch created! To: Eli Zaretskii Cc: Simon Marchi , GDB Patches Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg00024.txt.bz2 On Thu, Feb 1, 2018 at 5:34 PM, Eli Zaretskii wrote: >> From: Yao Qi >> Date: Thu, 1 Feb 2018 16:51:36 +0000 >> Cc: Simon Marchi , GDB Patches >> >> On Thu, Feb 1, 2018 at 4:27 PM, Eli Zaretskii wrote: >> > Maybe I'm missing something, but isn't the commit log entry supposed >> > to have the same text as the ChangeLog for that change? >> >> My understanding is that ChangeLog entry should be copied at the end >> of commit log > > I believe I did that, except that I moved the motivation for the > change before the ChangeLog header, as it belongs to the preamble of > the Git log. (In ChangeLog, there's no subdivision of the entry.) > It is absolutely fine to put the reason of the change in the commit log, but it is questionable to put commit log into ChangeLog. At least, nowadays, "commit log" is more than ChangeLog entry. This is the convention we followed for several years. >> > And what's wrong with having error messages in ChangeLog's, anyway? >> >> Each entry in ChangeLog describes the changes to the code, >> https://www.gnu.org/prep/standards/standards.html#Change-Log-Concepts >> IMO, error messages are out of the scope of what ChangeLog is intended >> to describe. > > This is changing, and some GNU projects already do it differently. I > believe the next version of standards.texi will change the > recommendations to be more lax. And using different style for each > project is a pain. Is GDB really so rigid as to not tolerate this? > GDB is evolving, so I am completely fine to changes, but you made the change of the way of writing changelog, which is not discussed before. > Please note that the error message I cited is just part of the > motivation for the change, so we are really talking about including > the motivation in the ChangeLog. > Yes, do we want to change the rule of writing ChangeLog, so that we can/should put the motivation for the change? Is the motivation mandatory in the changelog or optional? >> Also, I've never seen such ChangeLog entry (with error messages) >> before. > > That's not necessarily a reason for rejecting such entries. > > So: what is the project's take on this, if there is one? We need a clear rule on writing changelog, otherwise how do we write changelog or review patches? --=20 Yao (=E9=BD=90=E5=B0=A7)