From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 109208 invoked by alias); 28 Jun 2016 14:41:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 109197 invoked by uid 89); 28 Jun 2016 14:41:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=mattered X-HELO: mail-oi0-f53.google.com Received: from mail-oi0-f53.google.com (HELO mail-oi0-f53.google.com) (209.85.218.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 28 Jun 2016 14:41:20 +0000 Received: by mail-oi0-f53.google.com with SMTP id u201so25570513oie.0 for ; Tue, 28 Jun 2016 07:41:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=oIfjW7Fx2kGPOAVS8QeUaeF2qJ0mK99ZhSYCCbqA25g=; b=ZisKd01o90hF+bkL1cbBfmA+s91TvMA7LWQ2u5TFBcKnM8ei687ayXT9P84RMfh5TL fUB35ky/7eWcKgN6Be2RmdK1eoZJldgskN3VPFD+n3EWaPA8E/YlSmitaQeK9G49WTW0 zV34JIk7yuBmFJLjAS1W8Qfr1ddEiyPpioY82d1sbXonbePcq8PJ8SbWiV28I7sfxDVZ ROcKnOejiGH61F4uPWswBqlnkH7KCpP7HyzDSr5AZGIU+WzunHjr9PW2TCu1gmnvqB9e ImPEbWHDNGBuaFVLHInlfX8PuaU4unCz0u2AgydzXtZuaU9tisV3qIK5G6lVYN89Xg9o raiw== X-Gm-Message-State: ALyK8tLzkqdba55lkdLERsl3lrqna19S/OYPPTyuAMktQondTm3h7EzcovLIXPS5+w0SECaj5FEQ8m+d8tIz1g== X-Received: by 10.157.11.230 with SMTP id 93mr2084214oth.103.1467124878384; Tue, 28 Jun 2016 07:41:18 -0700 (PDT) MIME-Version: 1.0 Received: by 10.202.182.130 with HTTP; Tue, 28 Jun 2016 07:41:18 -0700 (PDT) In-Reply-To: <1465248812-23902-5-git-send-email-tom@tromey.com> References: <1465248812-23902-1-git-send-email-tom@tromey.com> <1465248812-23902-5-git-send-email-tom@tromey.com> From: Yao Qi Date: Tue, 28 Jun 2016 14:41:00 -0000 Message-ID: Subject: Re: [RFA 4/6] Remove some variables but call functions for side effects To: Tom Tromey Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-06/txt/msg00465.txt.bz2 On Mon, Jun 6, 2016 at 10:33 PM, Tom Tromey wrote: > This patch consolidates the (possibly-questionable) spots where we > remove a declaration but continue to call some function for side > effects. In a couple of cases it wasn't entirely clear to me that > this mattered; and in some other cases it might be more aesthetically > pleasing to use ATTRIBUTE_UNUSED. So, I broke this out into a > separate patch for simpler review. > > 2016-06-06 Tom Tromey > > * arch-utils.c (default_skip_permanent_breakpoint): Remove > "bp_insn". > * disasm.c (do_assembly_only): Remove "num_displayed". > * dwarf2read.c (read_abbrev_offset): Remove "length". > (dwarf_decode_macro_bytes) : Remove > "constant". > * m32c-tdep.c (make_regs): Remove "r2hl", "r3hl", and "intbhl". > * microblaze-tdep.c (microblaze_frame_cache): Remove "func". > * tracefile.c (trace_save): Remove "status". Patch is good to me. --=20 Yao (=E9=BD=90=E5=B0=A7)