From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28350 invoked by alias); 18 Jan 2018 21:12:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28336 invoked by uid 89); 18 Jan 2018 21:12:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=bringing, terminal X-HELO: mail-qt0-f175.google.com Received: from mail-qt0-f175.google.com (HELO mail-qt0-f175.google.com) (209.85.216.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 18 Jan 2018 21:12:49 +0000 Received: by mail-qt0-f175.google.com with SMTP id o35so23708595qtj.13 for ; Thu, 18 Jan 2018 13:12:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=F/Zf28STehLP4QZjL7EVfPr0Yl548qecLonZ2Byup6g=; b=ry6OUUfgha3PI3QEo40UzZtc+M4/uYrQ6HI1GaPZoW6Z75+lM6p9mnKCf9lNAqP5Ey ObT/nshFOrjhpEBHnMKdeyN90ZWi2wlUqZsV9VXyBxEB6eHobOdfmwYkI0zO31R0e29w 8lBYBNyDO8e7KhwhF/DypT1eA78UTOevCX40GBaIHJEKlH5CjU4+DU4ohyOi7C5PMYWs 8vMcdff7i/KcZZu3/+7Vkm+1t3onYNu02OSy6pcD2nlhk4X8omU12mvhzt1eDXGbQWj3 NtjHybFRPPGZC1OG6F5Qh+Aaa8wrNbNawPtV0QEamWrMm6L4a0TtwVM6skq1sTNe00Gz aKUg== X-Gm-Message-State: AKwxyteLtlUdcso5AjlQxJC/HaXOIJDYl4nw5kv0Wc8Jlt7osLMZ2CTo u61X3KjeIIMqEz8D22Ffa2S9fg7p7r9VBdZD4Ng= X-Google-Smtp-Source: ACJfBosk5KkcrPdyrigOAokP9qt/jXeQLrCzkwkTuslOmozAbZ3kfi39mlXR/+M7Nh8uTGjutxiMB9KREzyrFSr0hD8= X-Received: by 10.55.104.1 with SMTP id d1mr1817297qkc.71.1516309968090; Thu, 18 Jan 2018 13:12:48 -0800 (PST) MIME-Version: 1.0 Received: by 10.12.152.176 with HTTP; Thu, 18 Jan 2018 13:12:47 -0800 (PST) In-Reply-To: References: <1515363510-18374-1-git-send-email-b7.10110111@gmail.com> <863733fb5p.fsf@gmail.com> From: Yao Qi Date: Thu, 18 Jan 2018 21:12:00 -0000 Message-ID: Subject: Re: [PATCH] Make tests expect [ \t]+ pattern instead of \t for "info reg" command To: Ruslan Kabatsayev Cc: GDB Patches Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2018-01/txt/msg00384.txt.bz2 On Thu, Jan 18, 2018 at 3:42 PM, Ruslan Kabatsayev wrote: > > For your questions of "what format" and "why current is bad" please > see my previously sent (but not applied) patch: > https://sourceware.org/ml/gdb-patches/2017-07/msg00046.html > (and its follow-up version 2: > https://sourceware.org/ml/gdb-patches/2017-07/msg00406.html ). > In short, "info reg" prints three columns, and the third one is > aligned by a single tab. This works well only in two cases: all > registers have short hex values (i.e. less than 8 chars wide), or all > have long values. Then the tab shifts the third column of values to > the same terminal character column. > Initially (in the patch linked above) I wanted to preserve the tab and > only pad it with subsequent spaces to a fixed column, thus avoiding > breaking the tests, but after the discussion I understood that it's > too hacky to be a solution, and it's better to fix the tests and then > use space-only alignment, similarly to what is done with the second > column. > > As for "some other patches", I don't have any particular change in > mind currently. > Thanks for bringing more context, which is helpful to understand the patch. It is good to me, you can push. --=20 Yao (=E9=BD=90=E5=B0=A7)