From: Yao Qi <qiyaoltc@gmail.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] [AArch64] Use int64_t for address offset
Date: Tue, 28 Jun 2016 16:27:00 -0000 [thread overview]
Message-ID: <CAH=s-PPMzesvqxau8Qp7uTjmG2VSC4zQJwFZ6f3V5YoxkSh3rg@mail.gmail.com> (raw)
In-Reply-To: <1465979890-14353-1-git-send-email-yao.qi@linaro.org>
On Wed, Jun 15, 2016 at 9:38 AM, Yao Qi <qiyaoltc@gmail.com> wrote:
> In AArch64 displaced stepping and fast tracepoint, GDB/GDBserver needs
> to check whether the offset can fit in the range. We are using int32_t
> for offset, it is sufficient to get an offset from an instruction, but
> it is not enough to get an offset from two addresses. For example,
> we have a BL in shared lib which is at 0x0000002000040774, and the
> scratch pad for displaced stepping is at 0x400698. The offset can't
> fit in 28 bit imm. However, since we are using int32_t for offset, GDB
> thinks the offset can fit it, and generate the B instruction with wrong
> offset.
>
> It fixes the following fail,
>
> -FAIL: gdb.base/dso2dso.exp: next over call to sub2
I pushed it in.
--
Yao (齐尧)
prev parent reply other threads:[~2016-06-28 16:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 8:38 Yao Qi
2016-06-28 16:27 ` Yao Qi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH=s-PPMzesvqxau8Qp7uTjmG2VSC4zQJwFZ6f3V5YoxkSh3rg@mail.gmail.com' \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).