From: Yao Qi <qiyaoltc@gmail.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Introduce and use disassembly_flags
Date: Sun, 12 Feb 2017 22:35:00 -0000 [thread overview]
Message-ID: <CAH=s-PPgERon+UL2BoHTARX+AUrZ+F4LGFw8Ms7sXguSR0Zv5w@mail.gmail.com> (raw)
In-Reply-To: <20170211031207.4682-1-simon.marchi@polymtl.ca>
On Sat, Feb 11, 2017 at 3:12 AM, Simon Marchi <simon.marchi@polymtl.ca> wrote:
> @@ -1220,12 +1220,11 @@ disassemble_command (char *arg, int from_tty)
> CORE_ADDR low, high;
> const char *name;
> CORE_ADDR pc;
> - int flags;
> + disassembly_flags flags;
> const char *p;
>
> p = arg;
> name = NULL;
> - flags = 0;
>
We don't need to initialize 'flags' to zero? The default construct of
enum_flags
doesn't nothing.
--
Yao (齐尧)
next prev parent reply other threads:[~2017-02-12 22:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-11 3:12 Simon Marchi
2017-02-12 22:35 ` Yao Qi [this message]
2017-02-18 19:20 ` Simon Marchi
2017-02-18 19:30 ` Yao Qi
2017-02-13 20:03 ` Luis Machado
2017-02-18 19:23 ` Simon Marchi
2017-02-20 20:23 ` Luis Machado
2017-02-20 20:37 ` Simon Marchi
2017-02-20 20:40 ` Luis Machado
2017-02-15 11:15 ` Pedro Alves
2017-02-18 19:27 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH=s-PPgERon+UL2BoHTARX+AUrZ+F4LGFw8Ms7sXguSR0Zv5w@mail.gmail.com' \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).