From: Yao Qi <qiyaoltc@gmail.com>
To: Tom Tromey <tom@tromey.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFA 1/3] Fix "fall through" comments
Date: Wed, 28 Sep 2016 21:51:00 -0000 [thread overview]
Message-ID: <CAH=s-PPkWgxefpzPXtQmdVC79-vWAKso+GDsVyyCf4jbA-pbgA@mail.gmail.com> (raw)
In-Reply-To: <8760phcamm.fsf@tromey.com>
On Tue, Sep 27, 2016 at 10:10 PM, Tom Tromey <tom@tromey.com> wrote:
>>>>>> "Yao" == Yao Qi <qiyaoltc@gmail.com> writes:
>
> Yao> clang has -Wimplicit-fallthrough as well, but warnings are suppressed in
> Yao> a different way. Do we need to suppress warnings generated by both gcc
> Yao> and clang?
>
> On my machine, clang won't build gdb. From memory there was at least
> some issue compiling .c files in c++ mode, but I think there were other
> problems as well.
We can use option '-x c++' to suppress the warnings, but you are right, there
are some other problems, like some warning options are unknown to clang.
>
> If clang support is desired, then yes, the correct approach is to
> replace the fall-through comments with a new attribute.
>
At least, I don't think of a reason that we don't support clang. clang(++)
support is not very good, but we shouldn't make it worse, IMO. I am open
to people's thoughts.
--
Yao (齐尧)
next prev parent reply other threads:[~2016-09-28 18:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 18:16 [RFA 0/3] Fix some -Wimplicit-fallthrough warnings Tom Tromey
2016-09-27 18:16 ` [RFA 1/3] Fix "fall through" comments Tom Tromey
2016-09-27 21:48 ` Yao Qi
2016-09-27 21:53 ` Tom Tromey
2016-09-28 21:51 ` Yao Qi [this message]
2016-09-28 21:58 ` Tom Tromey
2016-09-30 21:09 ` Yao Qi
2016-09-27 18:16 ` [RFA 2/3] Add missing ATTRIBUTE_NORETURNs Tom Tromey
2016-09-28 7:28 ` Yao Qi
2016-09-28 17:40 ` Tom Tromey
2016-09-28 17:41 ` Yao Qi
2016-09-27 18:52 ` [RFA 3/3] Fix "obvious" fall-through warnings Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH=s-PPkWgxefpzPXtQmdVC79-vWAKso+GDsVyyCf4jbA-pbgA@mail.gmail.com' \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).